Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secret loading #3620

Merged
merged 12 commits into from
Apr 29, 2024
Merged

Fix secret loading #3620

merged 12 commits into from
Apr 29, 2024

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Apr 16, 2024 •
edited
Loading

closes #3013
closes #3090

changes

  • allow list and get global secrets as "normal" user without being an admin
  • fix some pagination bugs (exp each array was modified and needed a copy)
  • use specified pagination page-size so we can avoid extra checks to notice that the last page is already reached
  • use pagination component with a load more button for secrets
  • added some tests

@qwerty287 qwerty287 added the bug Something isn't working label Apr 16, 2024
@anbraten anbraten marked this pull request as ready for review April 24, 2024 12:47
qwerty287
qwerty287 approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested

@anbraten anbraten enabled auto-merge (squash) April 29, 2024 19:24
@anbraten anbraten merged commit ae14150 into woodpecker-ci:main Apr 29, 2024
6 of 7 checks passed
@woodpecker-bot
Copy link
Collaborator

Tearing down https://woodpecker-ci-woodpecker-pr-3620.surge.sh

@woodpecker-bot woodpecker-bot mentioned this pull request Apr 29, 2024
Merged
1 task
@anbraten anbraten deleted the fix-secrets branch April 29, 2024 20:19
@BrewTestBot BrewTestBot mentioned this pull request Jun 1, 2024
Merged
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@anbraten @6543
Fix secret loading (woodpecker-ci#3620)
c8a3e59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@anbraten @woodpecker-bot @qwerty287