Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ImagePullBackOff pod status #3580

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

eliasscosta
Copy link
Contributor

close: #3555

Put the same logic from waitStep and call the function isImagePullBackOffState in the tailStep function.

@qwerty287 qwerty287 added bug Something isn't working backend/kubernetes labels Apr 2, 2024
@qwerty287 qwerty287 added this to the 2.5.0 milestone Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 35.98%. Comparing base (b8763a8) to head (6e509eb).

❗ Current head 6e509eb differs from pull request most recent head 39e8f85. Consider uploading reports for the commit 39e8f85 to get more accurate results

Files Patch % Lines
pipeline/backend/kubernetes/kubernetes.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3580      +/-   ##
==========================================
+ Coverage   35.92%   35.98%   +0.06%     
==========================================
  Files         231      231              
  Lines       15603    15554      -49     
==========================================
- Hits         5605     5597       -8     
+ Misses       9581     9540      -41     
  Partials      417      417              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anbraten anbraten changed the title fix: pipeline freezing with pod satus ImagePullBackOff Handle ImagePullBackOff pod status Apr 15, 2024
@anbraten anbraten enabled auto-merge (squash) April 15, 2024 06:58
@anbraten anbraten merged commit f211a78 into woodpecker-ci:main Apr 15, 2024
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 15, 2024
1 task
@woodpecker-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/kubernetes bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step freezes when container image can't be pulled (ImagePullBackOff)
4 participants