-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to store logs in files #3568
Conversation
In it's current state, this allows to store logs in files on the regular filesystem. Do we need native support for something like S3 or can we just ask users to mount it directly into the FS? |
Native S3.
Sadly, there is no description in the issue, but I suppose it is related to growing Database. If so, tiering across storage mediums could be implemented.
That said, this PR adds a value, therefore it can be merged, but without closing the issue. |
Yes, I also think so.
I get your point, but this looks pretty complicated instead of just deleting the pipelines/logs what is the idea in the linked issue.
Probably it's best to just merge this how it's now, but keep the discussion open and ask there what the requirements are. |
Deployment of preview was torn down |
Could we try to merge #3722 first or do you think they wouldn't conflict that much? |
I don't think there are many conflicts, this is only about the storing. I took a quick look at your changes and it looks like you didn't change it (the db methods)? |
Co-authored-by: Anbraten <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3568 +/- ##
==========================================
- Coverage 25.87% 25.81% -0.06%
==========================================
Files 361 362 +1
Lines 26667 26725 +58
==========================================
Hits 6899 6899
- Misses 19235 19293 +58
Partials 533 533 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Anbraten <[email protected]>
#2278