-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cli version comparison and improve setup #3518
Conversation
This version check implementation has the same issue as the one in the UI. If a "dev" version from a commit is used, it complains. Is this also fixed? Or expected? |
For development versions it will skip the check. For pre-releases / next versions it will show you the hint to update to the latest stable, that should be okay however, I guess. |
Thanks 👍 |
@anbraten two questions about the version:
|
Should answer "What happens with next- version?"
|
Ah sorry, I missed the word "next" there and thought you mean RCs... |
Adjusted the code to use our |
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3518.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, untested
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3518 +/- ##
==========================================
- Coverage 36.04% 35.82% -0.23%
==========================================
Files 229 232 +3
Lines 15493 15668 +175
==========================================
+ Hits 5585 5613 +28
- Misses 9502 9636 +134
- Partials 406 419 +13 ☔ View full report in Codecov by Sentry. |
Fixed the wrong url string in the code and added a test. Also tested it again. Seems to work now. |
@@ -58,7 +58,7 @@ func After(_ *cli.Context) error { | |||
select { | |||
case <-waitForUpdateCheck.Done(): | |||
// When the actual command already finished, we still wait 250ms for the update check to finish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Desc is wrong now.
No description provided.