Fix uppercased env #3516
Merged
Fix uppercased env #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Uh... Do you know which PR has introduced it? |
xoxys
reviewed
Mar 20, 2024
lafriks
approved these changes
Mar 20, 2024
|
Lint fail is unrelated and seems to be caused by golangci update: https://ci.woodpecker-ci.org/repos/3780/pipeline/14125/30 |
I can take care in a dedicated PR if you like. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3516 +/- ##
==========================================
- Coverage 36.08% 36.06% -0.02%
==========================================
Files 229 229
Lines 15480 15483 +3
==========================================
- Hits 5586 5584 -2
- Misses 9488 9493 +5
Partials 406 406 ☔ View full report in Codecov by Sentry. |
6543
added a commit
that referenced
this pull request
Mar 20, 2024
This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `2.4.1` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [2.4.1](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.4.1) - 2024-03-20 ### 🔒 Security - Only allow to deploy from push, tag and release [[#3522](#3522)] ### 🐛 Bug Fixes - Exclude setup from cli command exec. [[#3523](#3523)] - Fix uppercased env [[#3516](#3516)] - Fix env schema [[#3514](#3514)] ### Misc - Temp pin golangci version in makefile [[#3520](#3520)] --------- Co-authored-by: qwerty287 <[email protected]> Co-authored-by: 6543 <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3515
I think after this is fixed, we should publish a new release as this can be quite important.