Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtimeClassName in Kubernetes backend options #3474

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

stevapple
Copy link
Contributor

@stevapple stevapple commented Mar 8, 2024

Resolves #3473

@zc-devs
Copy link
Contributor

zc-devs commented Mar 9, 2024

Schema suggestion: fixed_schema.patch

@stevapple
Copy link
Contributor Author

Schema suggestion: fixed_schema.patch

Looks quite reasonable, will take it. Thanks!

Should I do the same gardening for serviceAccountName, or leave it to another PR?

@zc-devs
Copy link
Contributor

zc-devs commented Mar 10, 2024

Should I do the same gardening for serviceAccountName, or leave it to another PR?

I like the idea. I would do it in separate PR.

@6543 6543 added this to the 2.5.0 milestone Mar 18, 2024
@stevapple
Copy link
Contributor Author

Ping for review/merge

@qwerty287
Copy link
Contributor

Should this be available to all repos/pipelines? Or can it be used to configure stuff that could be dangerous and therefore is only allowed in trusted repos?

@stevapple
Copy link
Contributor Author

stevapple commented Mar 29, 2024

Should this be available to all repos/pipelines?

I think it should.

Or can it be used to configure stuff that could be dangerous and therefore is only allowed in trusted repos?

At least this was clarified in the KEP proposal, that security is a non-goal for this feature, and RuntimeClass is not restricted by the Kubernetes RBAC system.

RuntimeClass should not be used a replacement for PodSecurityPolicy. The use cases for defining multiple RuntimeClasses for the same underlying runtime implementation should be extremely limited (generally only around updates & rollouts). To enforce this, no authorization or restrictions are placed directly on RuntimeClass use; in order to restrict a user to a specific RuntimeClass, you must use another policy mechanism such as PodSecurityPolicy.

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Mar 29, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3474.surge.sh

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.00%. Comparing base (2029813) to head (d4d5312).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3474   +/-   ##
=======================================
  Coverage   35.99%   36.00%           
=======================================
  Files         231      231           
  Lines       15542    15543    +1     
=======================================
+ Hits         5595     5596    +1     
  Misses       9530     9530           
  Partials      417      417           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit e1b574a into woodpecker-ci:main Mar 29, 2024
9 checks passed
@stevapple stevapple deleted the runtime-class-name branch March 29, 2024 09:37
@woodpecker-bot woodpecker-bot mentioned this pull request Mar 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/kubernetes enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for setting runtime class on Kubernetes backend
5 participants