-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtimeClassName
in Kubernetes backend options
#3474
Conversation
2878324
to
8ebe0fe
Compare
Schema suggestion: fixed_schema.patch |
Looks quite reasonable, will take it. Thanks! Should I do the same gardening for |
I like the idea. I would do it in separate PR. |
c3ee72f
to
8902d08
Compare
8902d08
to
1f8d575
Compare
Ping for review/merge |
Should this be available to all repos/pipelines? Or can it be used to configure stuff that could be dangerous and therefore is only allowed in trusted repos? |
I think it should.
At least this was clarified in the KEP proposal, that security is a non-goal for this feature, and
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3474.surge.sh |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3474 +/- ##
=======================================
Coverage 35.99% 36.00%
=======================================
Files 231 231
Lines 15542 15543 +1
=======================================
+ Hits 5595 5596 +1
Misses 9530 9530
Partials 417 417 ☔ View full report in Codecov by Sentry. |
Resolves #3473