CLI: remove step logs #3458
Merged
CLI: remove step logs #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
reviewed
Mar 1, 2024
Co-authored-by: 6543 <[email protected]>
|
Well you still have to adjust the code as So instead of: use |
|
TLDR: Made separate library call. Should not be a breaking too. Looks like it is not many step IDs, but any optional argument. So, I could make it Next question is why are optional args integers only? Then it should be Then we should distinct that arguments somehow. So, it probably would be a map (argName:argValue). |
zc-devs
force-pushed
the
3451-cli-remove-step-logs
branch
from
e67b605
to
ab16abe
Compare
qwerty287
added
enhancement
|
@zc-devs I updated the branch and resolved the conflicts. Is it ready for review? |
|
Let's try. Add |
qwerty287
added
the
build_pr_images
|
Done, triggers on next commit |
qwerty287
reviewed
Apr 15, 2024
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3458.surge.sh |
qwerty287
reviewed
Apr 20, 2024
Co-authored-by: qwerty287 <[email protected]>
qwerty287
approved these changes
Apr 22, 2024
|
@zc-devs Format check fails, please run |
anbraten
added
feature
6543
added a commit
to 6543-forks/woodpecker
that referenced
this pull request
Sep 5, 2024
On top of woodpecker-ci#3451, addresses [PR note](woodpecker-ci#3451 (comment)) related to woodpecker-ci#1100 Not tested. --------- Co-authored-by: 6543 <[email protected]> Co-authored-by: qwerty287 <[email protected]> Co-authored-by: qwerty287 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #3451, addresses PR note
related to #1100
Not tested.