Add release types #3303

anbraten · 2024-01-31T09:58:19Z

No description provided.

qwerty287 · 2024-01-31T10:04:44Z

Copied from #3300:

So should we add a note to the docs and maybe the CI_RELEASE_TYPE directly?

Docs yes, but adding the var yet is not necessary I think.

Can drafts be a prerelease? Then we shouldn't have CI_RELEASE_TYPE, but CI_RELEASE_PRE_RELEASE (exists already as CI_COMMIT_PRERELEASE) and CI_RELEASE_DRAFT.

If we go with two separate env vars, we even do not need to adjust docs but can just add the draft env var later.

About the env naming: All vars related to the forge event are currently prefixed with CI_COMMIT_, e.g. CI_COMMIT_PRERELEASE or CI_COMMIT_PULL_REQUEST_LABELS. Maybe it would be good to find better names here, but for now, I'd go with CI_COMMIT_RELEASE_DRAFT or something similar for the draft var.

qwerty287 · 2024-01-31T10:05:27Z

I'm fine with this change, but my main question is: Can drafts be a prerelease?

anbraten · 2024-01-31T10:11:10Z

I'm fine with this change, but my main question is: Can drafts be a prerelease?

You are right. It is possible to have draft pre-releases. I will revert my changes and just leave the note that release contains all types for now.

woodpecker-bot · 2024-01-31T13:35:01Z

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3303.surge.sh

codecov · 2024-01-31T15:13:21Z

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (da7d3f5) 35.41% compared to head (1ab94d6) 35.69%.
Report is 9 commits behind head on main.

Files	Patch %	Lines
server/forge/github/github.go	0.00%	42 Missing ⚠️
server/forge/gitea/gitea.go	0.00%	29 Missing and 1 partial ⚠️
pipeline/frontend/yaml/compiler/convert.go	59.09%	8 Missing and 1 partial ⚠️
server/api/queue.go	0.00%	9 Missing ⚠️
server/forge/gitlab/convert.go	83.33%	4 Missing and 2 partials ⚠️
server/pipeline/create.go	0.00%	5 Missing ⚠️
pipeline/frontend/metadata/environment.go	0.00%	4 Missing ⚠️
pipeline/frontend/yaml/parse.go	60.00%	3 Missing and 1 partial ⚠️
server/pipeline/stepbuilder/stepBuilder.go	0.00%	4 Missing ⚠️
pipeline/frontend/yaml/linter/linter.go	0.00%	0 Missing and 3 partials ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3303      +/-   ##
==========================================
+ Coverage   35.41%   35.69%   +0.27%     
==========================================
  Files         227      228       +1     
  Lines       14902    15102     +200     
==========================================
+ Hits         5278     5391     +113     
- Misses       9228     9318      +90     
+ Partials      396      393       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qwerty287 · 2024-01-31T16:04:58Z

server/api/queue.go

@@ -0,0 +1,21 @@
+package api


@pat-s why did you add this file?

Because its below api/ and all other files on the same level also have it. Without it, there's also a lint error.

Sorry, I still don't get it.

What is this doing and why do we need it? (I refer to the whole file, not only the package statement.)

This func registers an http path to stdlib handler. Where is the func called? Where is the stdlib http server is used?

What's the lint error, can you link a pipeline run where it failed? I didn't find one.

Sorry for the questions, but this looks completely wrong for me and I don't understand it.

And it uses a var stats that's encoded to json but this variable never has a value!?

Oh no, I just realized what happened.

This was a dangling file in my git repo from some unrelated "playing around" and I thought it belongs to this PR. The last commit from @anbraten failed and only wanted to fix the linter issue and didn't see that this file actually doesn't belong to my PR.

It shouldn't be in. I'll remove it immediately. 🤦

This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `2.3.0` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ### ✨ Features - Add release event [[#3226](#3226)] ### 📚 Documentation - Add release types [[#3303](#3303)] - Add opencollective footer [[#3281](#3281)] - Use array syntax in docs [[#3242](#3242)] ### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation [[#3299](#3299)] - Fix agent updating [[#3287](#3287)] - Sanitize pod's step label [[#3275](#3275)] - Pipeline errors must be an array [[#3276](#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID [[#3265](#3265)] - fix: bug pod service without label service [[#3256](#3256)] - Fix disabling PRs [[#3258](#3258)] - fix: bug annotations [[#3255](#3255)] ### 📈 Enhancement - Update theme on system color mode change [[#3296](#3296)] - Improve secrets availability checks [[#3271](#3271)] - Load more pipeline log lines (500 => 5000) [[#3212](#3212)] - Clean up models [[#3228](#3228)] ### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 [[#3294](#3294)] - fix(deps): update docs npm deps non-major [[#3295](#3295)] - Remove deprecated `group` from config [[#3289](#3289)] - Add spellcheck config [[#3018](#3018)] - fix(deps): update golang (packages) [[#3284](#3284)] - chore(deps): lock file maintenance [[#3274](#3274)] - chore(deps): update web npm deps non-major [[#3273](#3273)] - Pin prettier version [[#3260](#3260)] - Fix prettier [[#3259](#3259)] - Update UI building in Makefile [[#3250](#3250)]

@qwerty287

See discussion in [`1ab94d6` (#3303)](1ab94d6#r1473078205) @qwerty287

Co-authored-by: pat-s <[email protected]>

This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `2.3.0` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ### ✨ Features - Add release event [[woodpecker-ci#3226](woodpecker-ci#3226)] ### 📚 Documentation - Add release types [[woodpecker-ci#3303](woodpecker-ci#3303)] - Add opencollective footer [[woodpecker-ci#3281](woodpecker-ci#3281)] - Use array syntax in docs [[woodpecker-ci#3242](woodpecker-ci#3242)] ### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation [[woodpecker-ci#3299](woodpecker-ci#3299)] - Fix agent updating [[woodpecker-ci#3287](woodpecker-ci#3287)] - Sanitize pod's step label [[woodpecker-ci#3275](woodpecker-ci#3275)] - Pipeline errors must be an array [[woodpecker-ci#3276](woodpecker-ci#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID [[woodpecker-ci#3265](woodpecker-ci#3265)] - fix: bug pod service without label service [[woodpecker-ci#3256](woodpecker-ci#3256)] - Fix disabling PRs [[woodpecker-ci#3258](woodpecker-ci#3258)] - fix: bug annotations [[woodpecker-ci#3255](woodpecker-ci#3255)] ### 📈 Enhancement - Update theme on system color mode change [[woodpecker-ci#3296](woodpecker-ci#3296)] - Improve secrets availability checks [[woodpecker-ci#3271](woodpecker-ci#3271)] - Load more pipeline log lines (500 => 5000) [[woodpecker-ci#3212](woodpecker-ci#3212)] - Clean up models [[woodpecker-ci#3228](woodpecker-ci#3228)] ### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 [[woodpecker-ci#3294](woodpecker-ci#3294)] - fix(deps): update docs npm deps non-major [[woodpecker-ci#3295](woodpecker-ci#3295)] - Remove deprecated `group` from config [[woodpecker-ci#3289](woodpecker-ci#3289)] - Add spellcheck config [[woodpecker-ci#3018](woodpecker-ci#3018)] - fix(deps): update golang (packages) [[woodpecker-ci#3284](woodpecker-ci#3284)] - chore(deps): lock file maintenance [[woodpecker-ci#3274](woodpecker-ci#3274)] - chore(deps): update web npm deps non-major [[woodpecker-ci#3273](woodpecker-ci#3273)] - Pin prettier version [[woodpecker-ci#3260](woodpecker-ci#3260)] - Fix prettier [[woodpecker-ci#3259](woodpecker-ci#3259)] - Update UI building in Makefile [[woodpecker-ci#3250](woodpecker-ci#3250)]

….0 (#707) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [woodpeckerci/woodpecker-server](https://github.com/woodpecker-ci/woodpecker) | minor | `v2.2.2` -> `v2.3.0` | --- ### Release Notes <details> <summary>woodpecker-ci/woodpecker (woodpeckerci/woodpecker-server)</summary> ### [`v2.3.0`](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.3.0): 2.3.0 [Compare Source](woodpecker-ci/woodpecker@v2.2.2...v2.3.0) #### [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ##### ❤️ Thanks to all contributors! ❤️ [@anbraten](https://github.com/anbraten), [@HerHde](https://github.com/HerHde), [@qwerty287](https://github.com/qwerty287), [@pat-s](https://github.com/pat-s), [@renovate](https://github.com/renovate)\[bot], [@lukashass](https://github.com/lukashass), [@zc-devs](https://github.com/zc-devs), [@Alonsohhl](https://github.com/Alonsohhl), [@healdropper](https://github.com/healdropper), [@eliasscosta](https://github.com/eliasscosta), [@runephilosof-karnovgroup](https://github.com/runephilosof-karnovgroup) ##### ✨ Features - Add release event \[[#3226](woodpecker-ci/woodpecker#3226)] ##### 📚 Documentation - Add release types \[[#3303](woodpecker-ci/woodpecker#3303)] - Add opencollective footer \[[#3281](woodpecker-ci/woodpecker#3281)] - Use array syntax in docs \[[#3242](woodpecker-ci/woodpecker#3242)] ##### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation \[[#3299](woodpecker-ci/woodpecker#3299)] - Fix agent updating \[[#3287](woodpecker-ci/woodpecker#3287)] - Sanitize pod's step label \[[#3275](woodpecker-ci/woodpecker#3275)] - Pipeline errors must be an array \[[#3276](woodpecker-ci/woodpecker#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID \[[#3265](woodpecker-ci/woodpecker#3265)] - fix: bug pod service without label service \[[#3256](woodpecker-ci/woodpecker#3256)] - Fix disabling PRs \[[#3258](woodpecker-ci/woodpecker#3258)] - fix: bug annotations \[[#3255](woodpecker-ci/woodpecker#3255)] ##### 📈 Enhancement - Update theme on system color mode change \[[#3296](woodpecker-ci/woodpecker#3296)] - Improve secrets availability checks \[[#3271](woodpecker-ci/woodpecker#3271)] - Load more pipeline log lines (500 => 5000) \[[#3212](woodpecker-ci/woodpecker#3212)] - Clean up models \[[#3228](woodpecker-ci/woodpecker#3228)] ##### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 \[[#3294](woodpecker-ci/woodpecker#3294)] - fix(deps): update docs npm deps non-major \[[#3295](woodpecker-ci/woodpecker#3295)] - Remove deprecated `group` from config \[[#3289](woodpecker-ci/woodpecker#3289)] - Add spellcheck config \[[#3018](woodpecker-ci/woodpecker#3018)] - fix(deps): update golang (packages) \[[#3284](woodpecker-ci/woodpecker#3284)] - chore(deps): lock file maintenance \[[#3274](woodpecker-ci/woodpecker#3274)] - chore(deps): update web npm deps non-major \[[#3273](woodpecker-ci/woodpecker#3273)] - Pin prettier version \[[#3260](woodpecker-ci/woodpecker#3260)] - Fix prettier \[[#3259](woodpecker-ci/woodpecker#3259)] - Update UI building in Makefile \[[#3250](woodpecker-ci/woodpecker#3250)] </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/707 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

…0 (#706) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [woodpeckerci/woodpecker-agent](https://github.com/woodpecker-ci/woodpecker) | minor | `v2.2.2` -> `v2.3.0` | --- ### Release Notes <details> <summary>woodpecker-ci/woodpecker (woodpeckerci/woodpecker-agent)</summary> ### [`v2.3.0`](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.3.0): 2.3.0 [Compare Source](woodpecker-ci/woodpecker@v2.2.2...v2.3.0) #### [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ##### ❤️ Thanks to all contributors! ❤️ [@anbraten](https://github.com/anbraten), [@HerHde](https://github.com/HerHde), [@qwerty287](https://github.com/qwerty287), [@pat-s](https://github.com/pat-s), [@renovate](https://github.com/renovate)\[bot], [@lukashass](https://github.com/lukashass), [@zc-devs](https://github.com/zc-devs), [@Alonsohhl](https://github.com/Alonsohhl), [@healdropper](https://github.com/healdropper), [@eliasscosta](https://github.com/eliasscosta), [@runephilosof-karnovgroup](https://github.com/runephilosof-karnovgroup) ##### ✨ Features - Add release event \[[#3226](woodpecker-ci/woodpecker#3226)] ##### 📚 Documentation - Add release types \[[#3303](woodpecker-ci/woodpecker#3303)] - Add opencollective footer \[[#3281](woodpecker-ci/woodpecker#3281)] - Use array syntax in docs \[[#3242](woodpecker-ci/woodpecker#3242)] ##### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation \[[#3299](woodpecker-ci/woodpecker#3299)] - Fix agent updating \[[#3287](woodpecker-ci/woodpecker#3287)] - Sanitize pod's step label \[[#3275](woodpecker-ci/woodpecker#3275)] - Pipeline errors must be an array \[[#3276](woodpecker-ci/woodpecker#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID \[[#3265](woodpecker-ci/woodpecker#3265)] - fix: bug pod service without label service \[[#3256](woodpecker-ci/woodpecker#3256)] - Fix disabling PRs \[[#3258](woodpecker-ci/woodpecker#3258)] - fix: bug annotations \[[#3255](woodpecker-ci/woodpecker#3255)] ##### 📈 Enhancement - Update theme on system color mode change \[[#3296](woodpecker-ci/woodpecker#3296)] - Improve secrets availability checks \[[#3271](woodpecker-ci/woodpecker#3271)] - Load more pipeline log lines (500 => 5000) \[[#3212](woodpecker-ci/woodpecker#3212)] - Clean up models \[[#3228](woodpecker-ci/woodpecker#3228)] ##### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 \[[#3294](woodpecker-ci/woodpecker#3294)] - fix(deps): update docs npm deps non-major \[[#3295](woodpecker-ci/woodpecker#3295)] - Remove deprecated `group` from config \[[#3289](woodpecker-ci/woodpecker#3289)] - Add spellcheck config \[[#3018](woodpecker-ci/woodpecker#3018)] - fix(deps): update golang (packages) \[[#3284](woodpecker-ci/woodpecker#3284)] - chore(deps): lock file maintenance \[[#3274](woodpecker-ci/woodpecker#3274)] - chore(deps): update web npm deps non-major \[[#3273](woodpecker-ci/woodpecker#3273)] - Pin prettier version \[[#3260](woodpecker-ci/woodpecker#3260)] - Fix prettier \[[#3259](woodpecker-ci/woodpecker#3259)] - Update UI building in Makefile \[[#3250](woodpecker-ci/woodpecker#3250)] </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/706 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

adjust release event docs

c9375cf

anbraten force-pushed the release-event branch from 72544cb to c9375cf Compare January 31, 2024 12:47

anbraten requested a review from qwerty287 January 31, 2024 12:47

anbraten added the documentation docu & docs label Jan 31, 2024

qwerty287 approved these changes Jan 31, 2024

View reviewed changes

pat-s added 2 commits January 31, 2024 16:01

prettier

962c74f

fix golang lint error

1ab94d6

pat-s merged commit 6ed1655 into main Jan 31, 2024
8 checks passed

pat-s deleted the release-event branch January 31, 2024 15:18

qwerty287 reviewed Jan 31, 2024

View reviewed changes

woodpecker-bot mentioned this pull request Jan 31, 2024

🎉 Release 2.3.0 #3249

Merged

1 task

pat-s added a commit that referenced this pull request Jan 31, 2024

Remove accidentally added file (#3304)

e85762f

See discussion in [`1ab94d6` (#3303)](1ab94d6#r1473078205) @qwerty287

BrewTestBot mentioned this pull request Jan 31, 2024

woodpecker-cli 2.3.0 Homebrew/homebrew-core#161434

Merged

fernandrone pushed a commit to quintoandar/woodpecker that referenced this pull request Feb 1, 2024

Add release types (woodpecker-ci#3303)

4968d40

Co-authored-by: pat-s <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add release types #3303

Add release types #3303

anbraten commented Jan 31, 2024

qwerty287 commented Jan 31, 2024

qwerty287 commented Jan 31, 2024

anbraten commented Jan 31, 2024

woodpecker-bot commented Jan 31, 2024 •

edited

Loading

codecov bot commented Jan 31, 2024

qwerty287 Jan 31, 2024

pat-s Jan 31, 2024

qwerty287 Jan 31, 2024 •

edited

Loading

qwerty287 Jan 31, 2024

pat-s Jan 31, 2024

Add release types #3303

Add release types #3303

Conversation

anbraten commented Jan 31, 2024

qwerty287 commented Jan 31, 2024

qwerty287 commented Jan 31, 2024

anbraten commented Jan 31, 2024

woodpecker-bot commented Jan 31, 2024 • edited Loading

codecov bot commented Jan 31, 2024

Codecov Report

qwerty287 Jan 31, 2024

Choose a reason for hiding this comment

pat-s Jan 31, 2024

Choose a reason for hiding this comment

qwerty287 Jan 31, 2024 • edited Loading

Choose a reason for hiding this comment

qwerty287 Jan 31, 2024

Choose a reason for hiding this comment

pat-s Jan 31, 2024

Choose a reason for hiding this comment

woodpecker-bot commented Jan 31, 2024 •

edited

Loading

qwerty287 Jan 31, 2024 •

edited

Loading