Improve secrets availability checks #3271

anbraten · 2024-01-24T16:15:47Z

closes #2800

return more specific errors for missing secrets
- secret not found
- secret not allowed to be used by event
- secret not allowed to be used by image
- secret is not a plugin
use some error handling for secrets and settings -> from_secret options

pipeline/frontend/yaml/compiler/convert.go

codecov · 2024-01-25T16:59:45Z

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (da7d3f5) 35.41% compared to head (8000a53) 35.57%.

Files	Patch %	Lines
pipeline/frontend/yaml/compiler/convert.go	59.09%	8 Missing and 1 partial ⚠️
server/pipeline/stepbuilder/stepBuilder.go	0.00%	4 Missing ⚠️
pipeline/frontend/yaml/compiler/settings/params.go	94.44%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3271      +/-   ##
==========================================
+ Coverage   35.41%   35.57%   +0.15%     
==========================================
  Files         227      227              
  Lines       14902    14916      +14     
==========================================
+ Hits         5278     5306      +28     
+ Misses       9228     9222       -6     
+ Partials      396      388       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pipeline/frontend/yaml/compiler/convert.go

…to fix-secrets-checl

This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `2.3.0` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ### ✨ Features - Add release event [[#3226](#3226)] ### 📚 Documentation - Add release types [[#3303](#3303)] - Add opencollective footer [[#3281](#3281)] - Use array syntax in docs [[#3242](#3242)] ### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation [[#3299](#3299)] - Fix agent updating [[#3287](#3287)] - Sanitize pod's step label [[#3275](#3275)] - Pipeline errors must be an array [[#3276](#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID [[#3265](#3265)] - fix: bug pod service without label service [[#3256](#3256)] - Fix disabling PRs [[#3258](#3258)] - fix: bug annotations [[#3255](#3255)] ### 📈 Enhancement - Update theme on system color mode change [[#3296](#3296)] - Improve secrets availability checks [[#3271](#3271)] - Load more pipeline log lines (500 => 5000) [[#3212](#3212)] - Clean up models [[#3228](#3228)] ### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 [[#3294](#3294)] - fix(deps): update docs npm deps non-major [[#3295](#3295)] - Remove deprecated `group` from config [[#3289](#3289)] - Add spellcheck config [[#3018](#3018)] - fix(deps): update golang (packages) [[#3284](#3284)] - chore(deps): lock file maintenance [[#3274](#3274)] - chore(deps): update web npm deps non-major [[#3273](#3273)] - Pin prettier version [[#3260](#3260)] - Fix prettier [[#3259](#3259)] - Update UI building in Makefile [[#3250](#3250)]

This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `2.3.0` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ### ✨ Features - Add release event [[woodpecker-ci#3226](woodpecker-ci#3226)] ### 📚 Documentation - Add release types [[woodpecker-ci#3303](woodpecker-ci#3303)] - Add opencollective footer [[woodpecker-ci#3281](woodpecker-ci#3281)] - Use array syntax in docs [[woodpecker-ci#3242](woodpecker-ci#3242)] ### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation [[woodpecker-ci#3299](woodpecker-ci#3299)] - Fix agent updating [[woodpecker-ci#3287](woodpecker-ci#3287)] - Sanitize pod's step label [[woodpecker-ci#3275](woodpecker-ci#3275)] - Pipeline errors must be an array [[woodpecker-ci#3276](woodpecker-ci#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID [[woodpecker-ci#3265](woodpecker-ci#3265)] - fix: bug pod service without label service [[woodpecker-ci#3256](woodpecker-ci#3256)] - Fix disabling PRs [[woodpecker-ci#3258](woodpecker-ci#3258)] - fix: bug annotations [[woodpecker-ci#3255](woodpecker-ci#3255)] ### 📈 Enhancement - Update theme on system color mode change [[woodpecker-ci#3296](woodpecker-ci#3296)] - Improve secrets availability checks [[woodpecker-ci#3271](woodpecker-ci#3271)] - Load more pipeline log lines (500 => 5000) [[woodpecker-ci#3212](woodpecker-ci#3212)] - Clean up models [[woodpecker-ci#3228](woodpecker-ci#3228)] ### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 [[woodpecker-ci#3294](woodpecker-ci#3294)] - fix(deps): update docs npm deps non-major [[woodpecker-ci#3295](woodpecker-ci#3295)] - Remove deprecated `group` from config [[woodpecker-ci#3289](woodpecker-ci#3289)] - Add spellcheck config [[woodpecker-ci#3018](woodpecker-ci#3018)] - fix(deps): update golang (packages) [[woodpecker-ci#3284](woodpecker-ci#3284)] - chore(deps): lock file maintenance [[woodpecker-ci#3274](woodpecker-ci#3274)] - chore(deps): update web npm deps non-major [[woodpecker-ci#3273](woodpecker-ci#3273)] - Pin prettier version [[woodpecker-ci#3260](woodpecker-ci#3260)] - Fix prettier [[woodpecker-ci#3259](woodpecker-ci#3259)] - Update UI building in Makefile [[woodpecker-ci#3250](woodpecker-ci#3250)]

….0 (#707) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [woodpeckerci/woodpecker-server](https://github.com/woodpecker-ci/woodpecker) | minor | `v2.2.2` -> `v2.3.0` | --- ### Release Notes <details> <summary>woodpecker-ci/woodpecker (woodpeckerci/woodpecker-server)</summary> ### [`v2.3.0`](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.3.0): 2.3.0 [Compare Source](woodpecker-ci/woodpecker@v2.2.2...v2.3.0) #### [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ##### ❤️ Thanks to all contributors! ❤️ [@anbraten](https://github.com/anbraten), [@HerHde](https://github.com/HerHde), [@qwerty287](https://github.com/qwerty287), [@pat-s](https://github.com/pat-s), [@renovate](https://github.com/renovate)\[bot], [@lukashass](https://github.com/lukashass), [@zc-devs](https://github.com/zc-devs), [@Alonsohhl](https://github.com/Alonsohhl), [@healdropper](https://github.com/healdropper), [@eliasscosta](https://github.com/eliasscosta), [@runephilosof-karnovgroup](https://github.com/runephilosof-karnovgroup) ##### ✨ Features - Add release event \[[#3226](woodpecker-ci/woodpecker#3226)] ##### 📚 Documentation - Add release types \[[#3303](woodpecker-ci/woodpecker#3303)] - Add opencollective footer \[[#3281](woodpecker-ci/woodpecker#3281)] - Use array syntax in docs \[[#3242](woodpecker-ci/woodpecker#3242)] ##### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation \[[#3299](woodpecker-ci/woodpecker#3299)] - Fix agent updating \[[#3287](woodpecker-ci/woodpecker#3287)] - Sanitize pod's step label \[[#3275](woodpecker-ci/woodpecker#3275)] - Pipeline errors must be an array \[[#3276](woodpecker-ci/woodpecker#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID \[[#3265](woodpecker-ci/woodpecker#3265)] - fix: bug pod service without label service \[[#3256](woodpecker-ci/woodpecker#3256)] - Fix disabling PRs \[[#3258](woodpecker-ci/woodpecker#3258)] - fix: bug annotations \[[#3255](woodpecker-ci/woodpecker#3255)] ##### 📈 Enhancement - Update theme on system color mode change \[[#3296](woodpecker-ci/woodpecker#3296)] - Improve secrets availability checks \[[#3271](woodpecker-ci/woodpecker#3271)] - Load more pipeline log lines (500 => 5000) \[[#3212](woodpecker-ci/woodpecker#3212)] - Clean up models \[[#3228](woodpecker-ci/woodpecker#3228)] ##### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 \[[#3294](woodpecker-ci/woodpecker#3294)] - fix(deps): update docs npm deps non-major \[[#3295](woodpecker-ci/woodpecker#3295)] - Remove deprecated `group` from config \[[#3289](woodpecker-ci/woodpecker#3289)] - Add spellcheck config \[[#3018](woodpecker-ci/woodpecker#3018)] - fix(deps): update golang (packages) \[[#3284](woodpecker-ci/woodpecker#3284)] - chore(deps): lock file maintenance \[[#3274](woodpecker-ci/woodpecker#3274)] - chore(deps): update web npm deps non-major \[[#3273](woodpecker-ci/woodpecker#3273)] - Pin prettier version \[[#3260](woodpecker-ci/woodpecker#3260)] - Fix prettier \[[#3259](woodpecker-ci/woodpecker#3259)] - Update UI building in Makefile \[[#3250](woodpecker-ci/woodpecker#3250)] </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/707 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

…0 (#706) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [woodpeckerci/woodpecker-agent](https://github.com/woodpecker-ci/woodpecker) | minor | `v2.2.2` -> `v2.3.0` | --- ### Release Notes <details> <summary>woodpecker-ci/woodpecker (woodpeckerci/woodpecker-agent)</summary> ### [`v2.3.0`](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.3.0): 2.3.0 [Compare Source](woodpecker-ci/woodpecker@v2.2.2...v2.3.0) #### [2.3.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.3.0) - 2024-01-31 ##### ❤️ Thanks to all contributors! ❤️ [@anbraten](https://github.com/anbraten), [@HerHde](https://github.com/HerHde), [@qwerty287](https://github.com/qwerty287), [@pat-s](https://github.com/pat-s), [@renovate](https://github.com/renovate)\[bot], [@lukashass](https://github.com/lukashass), [@zc-devs](https://github.com/zc-devs), [@Alonsohhl](https://github.com/Alonsohhl), [@healdropper](https://github.com/healdropper), [@eliasscosta](https://github.com/eliasscosta), [@runephilosof-karnovgroup](https://github.com/runephilosof-karnovgroup) ##### ✨ Features - Add release event \[[#3226](woodpecker-ci/woodpecker#3226)] ##### 📚 Documentation - Add release types \[[#3303](woodpecker-ci/woodpecker#3303)] - Add opencollective footer \[[#3281](woodpecker-ci/woodpecker#3281)] - Use array syntax in docs \[[#3242](woodpecker-ci/woodpecker#3242)] ##### 🐛 Bug Fixes - Fix Gitpod: Gitea auth token creation \[[#3299](woodpecker-ci/woodpecker#3299)] - Fix agent updating \[[#3287](woodpecker-ci/woodpecker#3287)] - Sanitize pod's step label \[[#3275](woodpecker-ci/woodpecker#3275)] - Pipeline errors must be an array \[[#3276](woodpecker-ci/woodpecker#3276)] - fix bitbucket SSO using UUID from bitbucket api response as ForgeRemoteID \[[#3265](woodpecker-ci/woodpecker#3265)] - fix: bug pod service without label service \[[#3256](woodpecker-ci/woodpecker#3256)] - Fix disabling PRs \[[#3258](woodpecker-ci/woodpecker#3258)] - fix: bug annotations \[[#3255](woodpecker-ci/woodpecker#3255)] ##### 📈 Enhancement - Update theme on system color mode change \[[#3296](woodpecker-ci/woodpecker#3296)] - Improve secrets availability checks \[[#3271](woodpecker-ci/woodpecker#3271)] - Load more pipeline log lines (500 => 5000) \[[#3212](woodpecker-ci/woodpecker#3212)] - Clean up models \[[#3228](woodpecker-ci/woodpecker#3228)] ##### Misc - chore(deps): update docker.io/techknowlogick/xgo docker tag to go-1.21.6 \[[#3294](woodpecker-ci/woodpecker#3294)] - fix(deps): update docs npm deps non-major \[[#3295](woodpecker-ci/woodpecker#3295)] - Remove deprecated `group` from config \[[#3289](woodpecker-ci/woodpecker#3289)] - Add spellcheck config \[[#3018](woodpecker-ci/woodpecker#3018)] - fix(deps): update golang (packages) \[[#3284](woodpecker-ci/woodpecker#3284)] - chore(deps): lock file maintenance \[[#3274](woodpecker-ci/woodpecker#3274)] - chore(deps): update web npm deps non-major \[[#3273](woodpecker-ci/woodpecker#3273)] - Pin prettier version \[[#3260](woodpecker-ci/woodpecker#3260)] - Fix prettier \[[#3259](woodpecker-ci/woodpecker#3259)] - Update UI building in Makefile \[[#3250](woodpecker-ci/woodpecker#3250)] </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/706 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

Fix secret exists check

444e86f

anbraten commented Jan 24, 2024

View reviewed changes

pipeline/frontend/yaml/compiler/convert.go Outdated Show resolved Hide resolved

anbraten commented Jan 24, 2024

View reviewed changes

pipeline/frontend/yaml/compiler/convert.go Outdated Show resolved Hide resolved

anbraten added 2 commits January 25, 2024 10:30

improve secret errors when fetching

923005e

improve error handling

038aea7

anbraten changed the title ~~Fix secret exists check~~ Improve secret available checks Jan 25, 2024

Merge branch 'main' into fix-secrets-checl

513daac

anbraten marked this pull request as ready for review January 25, 2024 09:52

anbraten added enhancement improve existing features ux user experience labels Jan 25, 2024

anbraten requested a review from a team January 25, 2024 09:54

anbraten commented Jan 25, 2024

View reviewed changes

pipeline/frontend/yaml/compiler/convert.go Show resolved Hide resolved

anbraten mentioned this pull request Jan 25, 2024

User secret not found when triggering deployment #3267

Closed

3 tasks

qwerty287 reviewed Jan 26, 2024

View reviewed changes

pipeline/frontend/yaml/compiler/convert.go Outdated Show resolved Hide resolved

anbraten added 6 commits January 27, 2024 12:01

check for available events

16b3796

Merge branch 'fix-secrets-checl' of github.com:anbraten/woodpecker in…

2211e46

…to fix-secrets-checl

improve checks

bb62507

Merge branch 'main' into fix-secrets-checl

a1b0b18

fix test

a84bf5a

Merge branch 'fix-secrets-checl' of github.com:anbraten/woodpecker in…

8000a53

…to fix-secrets-checl

qwerty287 approved these changes Jan 27, 2024

View reviewed changes

anbraten merged commit 0b5eef7 into woodpecker-ci:main Jan 27, 2024
8 checks passed

anbraten changed the title ~~Improve secret available checks~~ Improve secrets availability checks Jan 27, 2024

anbraten deleted the fix-secrets-checl branch January 27, 2024 19:59

woodpecker-bot mentioned this pull request Jan 27, 2024

🎉 Release 2.3.0 #3249

Merged

1 task

BrewTestBot mentioned this pull request Jan 31, 2024

woodpecker-cli 2.3.0 Homebrew/homebrew-core#161434

Merged

fernandrone pushed a commit to quintoandar/woodpecker that referenced this pull request Feb 1, 2024

Improve secret availability checks (woodpecker-ci#3271)

0163c42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve secrets availability checks #3271

Improve secrets availability checks #3271

anbraten commented Jan 24, 2024 •

edited

Loading

codecov bot commented Jan 25, 2024 •

edited

Loading

Improve secrets availability checks #3271

Improve secrets availability checks #3271

Conversation

anbraten commented Jan 24, 2024 • edited Loading

codecov bot commented Jan 25, 2024 • edited Loading

Codecov Report

anbraten commented Jan 24, 2024 •

edited

Loading

codecov bot commented Jan 25, 2024 •

edited

Loading