Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug pod service without label service #3256

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix: bug pod service without label service #3256

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e742524
fix: pod service without label service
eliasscosta Jan 22, 2024
bf14c88
chore: fix lint
eliasscosta Jan 22, 2024
408cda3
Merge branch 'main' into fix-service-pod-without-label-service
qwerty287 Jan 22, 2024
f3a8b05
Merge branch 'main' into fix-service-pod-without-label-service
eliasscosta Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pipeline/backend/kubernetes/pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@
}
meta.Labels[StepLabel] = step.Name

if step.Type == types.StepTypeService {
meta.Labels[ServiceLabel] = step.Name
}

Check warning on line 85 in pipeline/backend/kubernetes/pod.go

View check run for this annotation

Codecov / codecov/patch

pipeline/backend/kubernetes/pod.go#L84-L85 

Added lines #L84 - L85 were not covered by tests

meta.Annotations = config.PodAnnotations
if meta.Annotations == nil {
meta.Annotations = make(map[string]string)
Expand Down
Loading