Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prefix from services #3079

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Remove prefix from services #3079

merged 3 commits into from
Jan 9, 2024

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 commented Dec 30, 2023 •
edited by 6543
Loading

supersedes #1960

Blocked by #3143

@qwerty287 qwerty287 added the build CI pipeline related label Dec 30, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3cf7b2) 34.99% compared to head (c799dc5) 34.97%.
Report is 3 commits behind head on main.

❗ Current head c799dc5 differs from pull request most recent head 273196a. Consider uploading reports for the commit 273196a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3079      +/-   ##
==========================================
- Coverage   34.99%   34.97%   -0.02%     
==========================================
  Files         228      228              
  Lines       14776    14792      +16     
==========================================
+ Hits         5171     5174       +3     
- Misses       9226     9238      +12     
- Partials      379      380       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287
Copy link
Contributor Author

Hmm this still doesn't work... https://ci.woodpecker-ci.org/repos/3780/pipeline/11286

@6543
Copy link
Member

6543 commented Dec 30, 2023

i wonder where we get the collision :/

6543
6543 requested changes Dec 30, 2023
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prevent accidental merge

@qwerty287 qwerty287 marked this pull request as draft December 31, 2023 07:40
@qwerty287 qwerty287 mentioned this pull request Jan 3, 2024
Closed
@qwerty287
Copy link
Contributor Author

-> #3109

@qwerty287 qwerty287 closed this Jan 3, 2024
@lafriks lafriks deleted the qwerty287-patch-1 branch January 3, 2024 15:57
@6543 6543 restored the qwerty287-patch-1 branch January 9, 2024 06:48
@6543 6543 reopened this Jan 9, 2024
@6543 6543 marked this pull request as ready for review January 9, 2024 17:35
@6543 6543 enabled auto-merge (squash) January 9, 2024 17:36
@6543 6543 merged commit d6b98cf into main Jan 9, 2024
6 checks passed
@6543 6543 deleted the qwerty287-patch-1 branch January 9, 2024 17:56
fernandrone pushed a commit to quintoandar/woodpecker that referenced this pull request Feb 1, 2024
@qwerty287 @6543 @fernandrone
Remove prefix from services (woodpecker-ci#3079)
34b2afb 
supersedes woodpecker-ci#1960

~~Blocked by woodpecker-ci#3143

Co-authored-by: 6543 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
build CI pipeline related skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwerty287 @6543 @anbraten