Show secrets from org and global level

[anbraten]

closes #2844

Screenshots

org-level:

repo-level:

new image filter UI:

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ff1f51d) 33.86% compared to head (6e3f233) 33.86%.
Report is 2 commits behind head on main.

❗ Current head 6e3f233 differs from pull request most recent head ecbfaf2. Consider uploading reports for the commit ecbfaf2 to get more accurate results

Files	Patch %	Lines
server/model/secret.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
- Coverage   33.86%   33.86%   -0.01%     
==========================================
  Files         219      219              
  Lines       13856    13858       +2     
==========================================
  Hits         4693     4693              
- Misses       8805     8807       +2     
  Partials      358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qwerty287]

I don't really know why, but this PR breaks repo secrets completely for me.

1. Creating a new repo secret fails with Error inserting secret "orga-sec-1". UNIQUE constraint failed: secrets.secret_org_id, secrets.secret_repo_id, secrets.secret_name
2. However, it looks like the secret is created anyways. Checking out main and running there shows the secret.
3. With this PR, the secret is not shown.

Looks like an issue with the org_id and repo_id cols in db (looking at these directly in DB they're set correctly though).
This is not what I wanted to test, but I can't try my scenarios as I can't create new repo secrets.

[qwerty287]

Yes, it seems to work in general now.
Some things I found:

1. Secrets are sorted by their name (alphabetically) always, but on top it should show repos, then org, then global
   
2. When opening the repo settings from the gear on the repo header, only the first page of repo secrets is shown (that's a general pagination issue, can be fixed in another PR)

And some general feedback (I'd open a new PR for this):

• show "user secret" instead of "organization secret" if the repo owner is a user
• show global secrets on org secrets page

[anbraten]

Sure we can sort them differently.

For the pagination we might consider a load more button in the future instead of the automatic scrolling part.

Showing user secret instead of org secret could be a bit tricky as we need to find out about that somehow, maybe we can by checking the fetched org.

[qwerty287]

Showing user secret instead of org secret could be a bit tricky as we need to find out about that somehow, maybe we can by checking the fetched org.

Yes, that's why I wrote to do it in another PR. I think though we have the org ID of the user already (global var with useConfig()) so we can just check for it. But let's move this to another PR.

[anbraten]

Yes, that's why I wrote to do it in another PR. I think though we have the org ID of the user already (global var with useConfig()) so we can just check for it. But let's move this to another PR.

But we need to check differently somehow as you can have admin rights to a private repo from someone else.

[qwerty287]

It's still not working as intended, it loads this order:

1. repo, page 1
2. repo, page 2
3. org, page 1
4. global, page 2

Repo has 3 repo secrets, no org secret and one global secret.

[anbraten]

Some edge cases

• repo has 3 pages, org 0 & global 0: fetch page 1,2,3 from repo, load empty page 1 from org, load empty page 1 from global
• repo is empty, org has 3 pages and global 0: load empty page 1 from repo, fetch page 1,2,3 from org, ...
• repo has 3 pages, org has a secret the same name as repo on page 1 which is on repo page 3: fetch 1,2,3 from repo, fetch page 1 from org and secret wont be shown as we already have it from repo, additional org secrets are shown

[qwerty287]

It's working for me correctly now