Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo listing #2855

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix repo listing #2855

merged 1 commit into from
Nov 22, 2023

Conversation

qwerty287
Copy link
Contributor

closes #2854

@qwerty287 qwerty287 added bug Something isn't working regression fix a bug that was not released yet labels Nov 22, 2023
@qwerty287 qwerty287 added this to the 2.0.0 milestone Nov 22, 2023
@qwerty287 qwerty287 requested a review from a team November 22, 2023 07:07
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (9d5ef11) 34.05% compared to head (1e9f882) 34.06%.
Report is 40 commits behind head on main.

Files Patch % Lines
pipeline/frontend/metadata/environment.go 0.00% 16 Missing ⚠️
server/api/repo.go 0.00% 11 Missing ⚠️
server/forge/gitlab/gitlab.go 50.00% 9 Missing ⚠️
server/store/datastore/xorm.go 0.00% 8 Missing ⚠️
server/api/login.go 0.00% 7 Missing ⚠️
shared/utils/slices.go 0.00% 7 Missing ⚠️
server/api/user.go 0.00% 5 Missing ⚠️
pipeline/frontend/yaml/compiler/cacher.go 0.00% 4 Missing ⚠️
server/forge/github/github.go 0.00% 4 Missing ⚠️
...erver/store/datastore/migration/027_link_to_url.go 40.00% 2 Missing and 1 partial ⚠️
... and 13 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2855   +/-   ##
=======================================
  Coverage   34.05%   34.06%           
=======================================
  Files         214      214           
  Lines       13779    13802   +23     
=======================================
+ Hits         4693     4702    +9     
- Misses       8714     8727   +13     
- Partials      372      373    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

For such essential code parts: can we add a test? (must not necessarily go in here due to time pressure of v2, but it might get forgotten otherwise)

@anbraten anbraten merged commit c9e5877 into woodpecker-ci:main Nov 22, 2023
8 checks passed
@qwerty287
Copy link
Contributor Author

For such essential code parts: can we add a test? (must not necessarily go in here due to time pressure of v2, but it might get forgotten otherwise)

Sure, tests are always good

@qwerty287 qwerty287 deleted the fix-list branch November 22, 2023 11:41
@qwerty287 qwerty287 mentioned this pull request Nov 22, 2023
6543 pushed a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression fix a bug that was not released yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add repository page is empty
3 participants