Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running tests on arm64 runners #2605

Merged
merged 42 commits into from
Apr 30, 2024
Merged

Allow running tests on arm64 runners #2605

merged 42 commits into from
Apr 30, 2024

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Oct 18, 2023

builds upon #2232

NB: the change pats22/xgo:go-1.21.3 is only as long as techknowlogick/xgo#224 is not yet merged and an arm image is available upstream.

@pat-s pat-s marked this pull request as ready for review October 20, 2023 15:17
@pat-s pat-s changed the title WIP: test building on arm Allow running tests on arm64 runners Oct 20, 2023
@6543
Copy link
Member

6543 commented Oct 20, 2023

Nice ... i still want to wait until xgo has the patches merged :)

@pat-s
Copy link
Contributor Author

pat-s commented Oct 20, 2023

Sure. Let's see how upstream goes. But a PoC was needed anyhow :)

@qwerty287 qwerty287 added the build CI pipeline related label Oct 23, 2023
@pat-s
Copy link
Contributor Author

pat-s commented Jan 6, 2024

nfpm fails :D

That issue looks unrelated AFAICS - it's not a compile issue but a missing file.

The issue is dist/server/linux/amd64/woodpecker-server" vs dist/server/linux_amd64/woodpecker-server" in the output locations.

I couldn't find a run where build-deb-rpm succeeded lately, so it might be a general issue unrelated to this PR.

@pat-s
Copy link
Contributor Author

pat-s commented Jan 6, 2024

Given that the xgo compiler seems working now, I think we should give it a go, i.e. deploy arm runners. There's a lot to gain/save and doing so might also help tech adding upstream support. What do you think?

I've cleaned up the PR dummy changes to make it potentially mergable.

@pat-s
Copy link
Contributor Author

pat-s commented Mar 19, 2024

Updated images to 1.22.1.

Feedback would be great ;)

@6543
Copy link
Member

6543 commented Mar 20, 2024

it did run on x86 right now ... let me change the autoscaler to spawn arm ... not jet but soon ish

@6543
Copy link
Member

6543 commented Mar 20, 2024

what we could do is to explizite lable workflows to use x86 and then cange it to arm in here ...

@pat-s
Copy link
Contributor Author

pat-s commented Mar 20, 2024

what we could do is to explizite lable workflows to use x86 and then cange it to arm in here ...

Certainly good for testing. But a bit of effort to do. Though I am meanwhile pretty sure the arm build fine.

@pat-s
Copy link
Contributor Author

pat-s commented Apr 9, 2024

@6543 A bit hard to make some progress here. I am slowly loosing motivation a bit as I can't do anything on my side anymore besides asking/pinging for external action. both here and in xgo.

If this is not important enough, we can also close it and just stay on amd64 (?).

@6543
Copy link
Member

6543 commented Apr 9, 2024

the only thing blocking it is techknowlogick/xgo#224

so we can just make the autoscaler more inteligent and deploy arm and only if needed by workflow (label selector) use x64

@pat-s
Copy link
Contributor Author

pat-s commented Apr 9, 2024

the only thing blocking it is techknowlogick/xgo#224

is not blocking, there is a functional image built from this PR under my account pats22 which is also referenced in this PR and tested to work in both ways.

@6543
Copy link
Member

6543 commented Apr 9, 2024

well in this case we can just use that meanwhile ... just add a codecoment (todo: switch to main once X is merged...)

@pat-s
Copy link
Contributor Author

pat-s commented Apr 10, 2024

well in this case we can just use that meanwhile ... just add a codecoment (todo: switch to main once X is merged...)

This is what I am trying to express since the last five comments or so 😅

Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some IDEs can create a tasks tree from TODO: commends.

.woodpecker/binaries.yaml Outdated Show resolved Hide resolved
.woodpecker/docker.yaml Outdated Show resolved Hide resolved
@pat-s pat-s merged commit 4d2610c into main Apr 30, 2024
6 of 7 checks passed
@pat-s pat-s deleted the arm branch April 30, 2024 10:51
@woodpecker-bot woodpecker-bot mentioned this pull request May 1, 2024
1 task
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
Co-authored-by: 6543 <[email protected]>
Co-authored-by: 6543 <[email protected]>
Co-authored-by: Robert Kaussow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build_pr_images If set, the CI will build images for this PR and push to Dockerhub build CI pipeline related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants