Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agent config file #1971

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Add agent config file #1971

merged 7 commits into from
Jul 12, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 10, 2023 •
edited
Loading

followup of #1888

witch makes it easy to extend without breaking things

@6543 6543 added the refactor delete or replace old code label Jul 10, 2023
@6543 6543 added this to the 1.0.0 milestone Jul 10, 2023
@6543 6543 added breaking will break existing installations if no manual action happens skip-changelog labels Jul 10, 2023
@6543
Copy link
Member Author

6543 commented Jul 10, 2023

it will break stuff if volume got RO intentionaly set ...

@6543 6543 requested a review from a team July 10, 2023 19:20
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Jul 10, 2023 •
edited
Loading

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1971.surge.sh

@6543 6543 added the agent label Jul 10, 2023
@6543 6543 removed the breaking will break existing installations if no manual action happens label Jul 11, 2023
@6543
Copy link
Member Author

6543 commented Jul 11, 2023 •
edited
Loading

feature-set & behaviour is the same, just an more generic way to be future-prove on how to de-/serialize config

in this case we only have the AgentID

@zc-devs
Copy link
Contributor

zc-devs commented Jul 11, 2023

feature-set & behaviour is the same, just an more generic way to be future-prove on how to de-/serialize config

in this case we only have the AgentID

was replied to my deleted message

It doesn't look as refactoring to me.

So, I agree.

@6543
Copy link
Member Author

6543 commented Jul 11, 2023

hu - who deleted your message?!?

@zc-devs
Copy link
Contributor

zc-devs commented Jul 11, 2023

Nobody, but me :(

Then I realized that it's just additional path for now -> previous behavior exists still -> may be refactoring :)

@zc-devs
Copy link
Contributor

zc-devs commented Jul 12, 2023

Maybe it's good idea to add VOLUME /etc/woodpecker in the Dokerfiles.

@6543
Copy link
Member Author

6543 commented Jul 12, 2023

Maybe it's good idea to add VOLUME /etc/woodpecker in the Dokerfiles.

that's for another pull

@codecov-commenter

This comment was marked as off-topic.

Sign in to view
@6543 6543 merged commit fa951a8 into woodpecker-ci:main Jul 12, 2023
@6543 6543 deleted the agent_config branch July 12, 2023 16:51
This was referenced Jul 12, 2023
Closed
Merged
@lafriks lafriks mentioned this pull request Jul 17, 2023
Closed
@zc-devs zc-devs mentioned this pull request Jul 23, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zc-devs zc-devs zc-devs left review comments

@jolheiser jolheiser jolheiser left review comments

@ttomasini ttomasini ttomasini left review comments

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
agent refactor delete or replace old code skip-changelog
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @woodpecker-bot @zc-devs @codecov-commenter @lafriks @ttomasini @jolheiser