Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully support .yaml #1713

Merged
merged 5 commits into from
Apr 29, 2023
Merged

Fully support .yaml #1713

merged 5 commits into from
Apr 29, 2023

Conversation

qwerty287
Copy link
Contributor

Follow-up to #1388
Closes #1073

@qwerty287 qwerty287 added the bug Something isn't working label Apr 22, 2023
@qwerty287 qwerty287 added this to the 1.0.0 milestone Apr 22, 2023
@qwerty287 qwerty287 requested a review from a team April 22, 2023 08:04
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Apr 22, 2023

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1713.surge.sh

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I acknowledge the consensus, that we should support yaml too ...

But I dont see why we should do a breaking change in the order and make yaml default over yml ?!?

@6543 6543 requested a review from anbraten April 22, 2023 19:50
@6543
Copy link
Member

6543 commented Apr 22, 2023

@anbraten your opinion?

@qwerty287
Copy link
Contributor Author

I changed it because .yaml is the recommended file extension and .yml is outdated. https://yaml.org/faq.html

@lafriks
Copy link
Contributor

lafriks commented Apr 24, 2023

I acknowledge the consensus, that we should support yaml too ...

But I dont see why we should do a breaking change in the order and make yaml default over yml ?!?

I don't think it's being breaking for many as there is already something very wrong if you have both .woodpecker.yml and .woodpecker.yaml in project

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2dd1b4f) 39.16% compared to head (d6c9306) 39.16%.

❗ Current head d6c9306 differs from pull request most recent head 2ebb106. Consider uploading reports for the commit 2ebb106 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1713   +/-   ##
=======================================
  Coverage   39.16%   39.16%           
=======================================
  Files         167      167           
  Lines       10778    10778           
=======================================
  Hits         4221     4221           
  Misses       6286     6286           
  Partials      271      271           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qwerty287 qwerty287 enabled auto-merge (squash) April 29, 2023 07:36
@qwerty287 qwerty287 merged commit cfdb32a into woodpecker-ci:master Apr 29, 2023
@qwerty287 qwerty287 deleted the yaml branch April 30, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer *.yaml over *.yml
5 participants