Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bitbucket Server branches #1698

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 commented Apr 7, 2023

Closes #1695

@qwerty287 qwerty287 added bug Something isn't working forge/bitbucket bitbucket forge related labels Apr 7, 2023
@qwerty287 qwerty287 added this to the 1.0.0 milestone Apr 7, 2023
@qwerty287 qwerty287 requested a review from a team April 7, 2023 12:30
@qwerty287 qwerty287 self-assigned this Apr 7, 2023
@qwerty287 qwerty287 removed their assignment Apr 7, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (ea95d5a) 39.14% compared to head (e997478) 39.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1698      +/-   ##
==========================================
- Coverage   39.14%   39.14%   -0.01%     
==========================================
  Files         167      167              
  Lines       10759    10760       +1     
==========================================
  Hits         4212     4212              
- Misses       6279     6280       +1     
  Partials      268      268              
Impacted Files Coverage Δ
cmd/agent/agent.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@6543
Copy link
Member

6543 commented Apr 7, 2023

@majodev could you check if it works, this pull do publishva test tag you can pull from dockerhub

@6543
Copy link
Member

6543 commented Apr 7, 2023

tag is pull_1698

@6543
Copy link
Member

6543 commented Apr 7, 2023

@qwerty287 can you at the json from the issue as fixture to add tests for parsing

@majodev
Copy link

majodev commented Apr 7, 2023

Can confirm getting branches from Bitbucket Server / Data Center works with woodpeckerci/woodpecker-server:pull_1698.

One Gotcha:

  • Output is currently limited to 25 branches (default applied if query parameter ?limit is not specified, see here).
  • This would either require:
    • looping through all returned pages (?limit=0 does not work for simply getting all, would just returning one entry)
    • or as a hacky workaround, you could pass ?limit=1000 (max limit allowed).

@qwerty287
Copy link
Contributor Author

Pagination is done in #1651 I'll do it there once this is merged.

@qwerty287
Copy link
Contributor Author

@6543 there are no tests for bitbucket server yet. I wouldn't add them here.

@6543 6543 merged commit 4b4d078 into woodpecker-ci:master Apr 7, 2023
@qwerty287 qwerty287 deleted the bb-branch branch April 8, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forge/bitbucket bitbucket forge related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitbucket Server / Data Center: List branches endpoint 404
4 participants