Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only grant privileged to plugins #1646

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Only grant privileged to plugins #1646

merged 2 commits into from
Mar 19, 2023

Conversation

qwerty287
Copy link
Contributor

Closes #1525

@qwerty287 qwerty287 added enhancement improve existing features security labels Mar 18, 2023
@qwerty287 qwerty287 added this to the 1.0.0 milestone Mar 18, 2023
@qwerty287 qwerty287 requested a review from a team March 18, 2023 14:32
@anbraten anbraten changed the title Do not grant privileges to privileged images if not used as plugins Only grant privileged to plugins Mar 18, 2023
@anbraten anbraten enabled auto-merge (squash) March 18, 2023 22:11
@anbraten anbraten merged commit 7ddc183 into woodpecker-ci:master Mar 19, 2023
@qwerty287 qwerty287 deleted the not-priv-if-no-plugin branch March 19, 2023 07:40
@6543 6543 mentioned this pull request Mar 20, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features security
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

default privileged plugins also are privileged when used as normal images
2 participants
@qwerty287 @anbraten