Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop coding support #1644

Merged
merged 4 commits into from
Mar 19, 2023
Merged

Drop coding support #1644

merged 4 commits into from
Mar 19, 2023

Conversation

qwerty287
Copy link
Contributor

Coding support is likely broken and nobody will ever fix it. Also it looks like nobody wants to use it, otherwise we would have get some bug reports.

@qwerty287 qwerty287 added the refactor delete or replace old code label Mar 18, 2023
@qwerty287 qwerty287 added this to the 1.0.0 milestone Mar 18, 2023
@qwerty287 qwerty287 requested a review from a team March 18, 2023 14:26
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Mar 18, 2023

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1644.surge.sh

@lafriks
Copy link
Contributor

lafriks commented Mar 18, 2023

Lint failures

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.88 ⚠️

Comparison is base (7ddc183) 40.76% compared to head (02f4615) 39.88%.

❗ Current head 02f4615 differs from pull request most recent head 243879d. Consider uploading reports for the commit 243879d to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
- Coverage   40.76%   39.88%   -0.88%     
==========================================
  Files         170      167       -3     
  Lines       11099    10752     -347     
==========================================
- Hits         4524     4288     -236     
+ Misses       6284     6190      -94     
+ Partials      291      274      -17     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qwerty287 qwerty287 enabled auto-merge (squash) March 19, 2023 06:41
@anbraten
Copy link
Member

@qwerty287 Could you add a note to the migration guide in the docs. That it got removed.

@qwerty287 qwerty287 disabled auto-merge March 19, 2023 06:53
@qwerty287 qwerty287 enabled auto-merge (squash) March 19, 2023 07:36
@qwerty287 qwerty287 merged commit 37dc8a4 into woodpecker-ci:master Mar 19, 2023
@qwerty287 qwerty287 deleted the drop-coding branch March 19, 2023 08:36
@6543 6543 added the breaking will break existing installations if no manual action happens label Mar 19, 2023
@anbraten anbraten mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking will break existing installations if no manual action happens refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants