Rework status constraint logic for successes #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since "success" and "failure" are the only two possible values, and "success" is considered to be included by default, the existing code can also be simplified a little. Fixes woodpecker-ci#1181
Codecov ReportBase: 42.01% // Head: 42.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
+ Coverage 42.01% 42.10% +0.09%
==========================================
Files 154 154
Lines 10578 10583 +5
==========================================
+ Hits 4444 4456 +12
+ Misses 5852 5845 -7
Partials 282 282
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lafriks
approved these changes
Jan 1, 2023
6543
reviewed
Jan 2, 2023
6543
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since "success" and "failure" are the only two possible values, and "success" is considered to be included by default, the existing code can also be simplified a little.
This has the side effect of ignoring the "exclude" part of the constraint completely. I put it in the tests just to make sure the workaround in #1181 (comment) continues to work as expected, but couldn't think of any legitimate use cases for it.
Fixes #1181