Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if repo exists before creating pipeline #1297

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Check if repo exists before creating pipeline #1297

merged 5 commits into from
Oct 21, 2022

Conversation

the-writer-dev
Copy link
Contributor

Link: #1257
I make sure to confirm the repo exists first before triggering the build and wrote a test to cover it.

@anbraten
Copy link
Member

Nice approach. Be careful with your code and don't forget to merge master as this is a bit behind. (build was renamed to pipeline)

@6543 6543 changed the title [issue #] 1257 Check if repo exists before creating build Check if repo exists before creating pipeline Oct 21, 2022
@6543
Copy link
Member

6543 commented Oct 21, 2022 •
edited
Loading

@bitethecode i first resolved merge conflicts and then adjust code to:

  • not use raw sql but xorm to check if repo exist
  • create a new error that can be checked if errors.Is(createPipelineError, types.RecordNotExist) as true and also print out nicely formated error msg

@6543
Copy link
Member

6543 commented Oct 21, 2022

thanks for the init pull :)

@6543 6543 added enhancement improve existing features server labels Oct 21, 2022
@6543 6543 added this to the 1.0.0 milestone Oct 21, 2022
@qwerty287
Copy link
Contributor

qwerty287 commented Oct 21, 2022 •
edited
Loading

@6543 it's kinda useless to approve your own commits :D

@the-writer-dev
Copy link
Contributor Author

@6543 Oh I was actually working on that merge conflicts and xorm. Okay, if that is done by your, I would stop

@6543
Copy link
Member

6543 commented Oct 21, 2022

@6543 it's kinda useless to approve your own commits :D

hehe - yes was waiting to see your response ;)

@6543
Copy link
Member

6543 commented Oct 21, 2022 •
edited
Loading

@6543 Oh I was actually working on that merge conflicts and xorm. Okay, if that is done by your, I would stop

oh sorry - if you want just adopt from me what you want and forcepushe your's over mine ...

@the-writer-dev
Copy link
Contributor Author

No issue here! Actually the implementation was almost identical so I'm okay with what you did!
@6543 btw, could you recommend any good issues I can pick up? I like to contribute more to this project!

@6543
Copy link
Member

6543 commented Oct 21, 2022 •
edited
Loading

hmm good question, we should chat about it via Discord/Matrix in the "Development" channel/room about it ;)

-> links to it is in our Readme as badge

@6543
Copy link
Member

6543 commented Oct 21, 2022 •
edited
Loading

@bitethecode I did missed to update the func names for the test ... (build -> pipeline)

waiting for u this time 👀 😅

@6543

This comment was marked as resolved.

Sign in to view
@6543 6543 enabled auto-merge (squash) October 21, 2022 23:05
@6543 6543 merged commit 186aee6 into woodpecker-ci:master Oct 21, 2022
simmstein pushed a commit to simmstein/woodpecker that referenced this pull request Dec 27, 2022
@the-writer-dev @simmstein
Check if repo exists before creating pipeline (woodpecker-ci#1297)
ed2569f 
Close woodpecker-ci#1257

make sure the repo exists first before triggering the pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features server
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@the-writer-dev @anbraten @6543 @qwerty287