-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax highlighting for pipeline config #1082
Add syntax highlighting for pipeline config #1082
Conversation
@lafriks Can we use prismjs to highlight yaml errors? I think it would be quite nice to show errors of the configuration using our editor/view in the long term. |
@anbraten where are yaml errors displayed? you mean my other PR? |
I can add that later on when this is merged |
Only drawback would be that it would require parsing yaml parser error messages |
0f92b5f
to
5b14fd4
Compare
It's definitely a task for a new PR. I just wanted to make sure prismjs supports additional highlighting like this underline wave other editors use to show errors in general. Couldn't find this exact use-case from a short search, but it seems primsjs supports some kind of plugin mechanism that could be used for it. |
Screenshots: