Pipeline compiler should not alter specified image

[6543]

address #1003

tested :)

[codecov-commenter]

Codecov Report

Merging #1005 (faf4153) into master (f21d854) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head faf4153 differs from pull request most recent head 8acb5f6. Consider uploading reports for the commit 8acb5f6 to get more accurate results

@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
- Coverage   50.47%   50.40%   -0.08%     
==========================================
  Files          83       83              
  Lines        6363     6363              
==========================================
- Hits         3212     3207       -5     
- Misses       2965     2970       +5     
  Partials      186      186              

Impacted Files	Coverage Δ
server/logging/log.go	48.83% <0.00%> (-5.82%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[6543]

let's wait ~1-2days and if no errors get reported it's fine

[thestr4ng3r]

You will still need to remove the workaround here, which was added for the old behavior:

diff --git a/pipeline/backend/local/local.go b/pipeline/backend/local/local.go
index e1215a00..cc636fb9 100644
--- a/pipeline/backend/local/local.go
+++ b/pipeline/backend/local/local.go
@@ -62,7 +62,7 @@ func (e *local) Exec(ctx context.Context, proc *types.Step) error {
                Command = append(Command, "plugin-git")
        } else {
                // Use "image name" as run command
-               Command = append(Command, proc.Image[18:len(proc.Image)-7])
+               Command = append(Command, proc.Image)
                Command = append(Command, "-c")

                // Decode script and delete initial lines

Otherwise this happens:

panic: runtime error: slice bounds out of range [18:2]

goroutine 44 [running]:
github.com/woodpecker-ci/woodpecker/pipeline/backend/local.(*local).Exec(0x1400026b920, {0x1011d0758?, 0x14000596940}, 0x140005dcd20)
	/Users/florian/dev/woodpecker/pipeline/backend/local/local.go:65 +0x8a0
github.com/woodpecker-ci/woodpecker/pipeline.(*Runtime).exec(0x1400052c070, 0x140005dcd20)
	/Users/florian/dev/woodpecker/pipeline/pipeline.go:216 +0x140
github.com/woodpecker-ci/woodpecker/pipeline.(*Runtime).execAll.func1()
	/Users/florian/dev/woodpecker/pipeline/pipeline.go:181 +0x1b8
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/Users/florian/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x5c
created by golang.org/x/sync/errgroup.(*Group).Go
	/Users/florian/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa4

If the slicing is removed, the changes work for my use-cases.

[thestr4ng3r]

Thanks a lot!