Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users for bad-habits and deprecations in configs #922

Closed
6543 opened this issue May 17, 2022 · 2 comments · Fixed by #1572
Closed

Warn users for bad-habits and deprecations in configs #922

6543 opened this issue May 17, 2022 · 2 comments · Fixed by #1572
Labels
cli enhancement improve existing features
Milestone

Comments

@6543
Copy link
Member

6543 commented May 17, 2022

I think woodpecker should ignore errors etc while cli lint should warn you if your config do have strange things ...

  • conditions that will never be true
  • filters that will never apply (event: tag & branch: main -> branch is ignored in all cases)
  • ...

Originally posted by @6543 in #921 (comment)

@6543 6543 added enhancement improve existing features cli labels May 17, 2022
@anbraten
Copy link
Member

Yeah we really need to give some love to the cli especially the lint and exec commands.

In general I would prefer to be as strict as possible with linting via cli and the server itself and at least be equal in both systems as that solves a lot of headache especially to new users like why is it throwing an error / showing a warning in the cli, but the server doesn't even care about it ...

@x80486
Copy link

x80486 commented Jul 6, 2022

There could be also a UI to accomplish this. A user just paste the pipeline definition and it will tell if there is anything wrong. In subsequent releases could be polished to say exactly where the problem is — if not supported by the CLI.

@anbraten anbraten mentioned this issue Sep 1, 2022
7 tasks
@anbraten anbraten added this to the 1.0.0 milestone Nov 26, 2022
@anbraten anbraten mentioned this issue Nov 26, 2022
31 tasks
@anbraten anbraten changed the title cli lint should warn you if your config do have strange things Warn users for bad-habits and deprecations in configs Nov 26, 2022
@6543 6543 modified the milestones: 1.0.0, 1.1.0 Jun 2, 2023
@pat-s pat-s modified the milestones: 2.0.0, 2.x.x Oct 13, 2023
@qwerty287 qwerty287 modified the milestones: 3.x.x, 2.0.0 Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli enhancement improve existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants