Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] we should only use one router framework #308

Closed
6543 opened this issue Sep 15, 2021 · 0 comments · Fixed by #382
Closed

[Refactor] we should only use one router framework #308

6543 opened this issue Sep 15, 2021 · 0 comments · Fixed by #382
Labels
refactor delete or replace old code

Comments

@6543
Copy link
Member

6543 commented Sep 15, 2021

we only should use one router - so use gin for all and if it does not support all there are other drop in replacements

(currently gin & httpservermux|treemux are used)

Originally posted by @6543 in #248 (comment)
@6543 6543 added the refactor delete or replace old code label Sep 15, 2021
@anbraten anbraten changed the title [Refactor] we only should use one router framework [Refactor] we should only use one router framework Sep 19, 2021
@anbraten anbraten mentioned this issue Sep 29, 2021
Merged
@6543 6543 closed this as completed in #382 Sep 29, 2021
6543 pushed a commit that referenced this issue Sep 29, 2021
@anbraten
Use go embed for web files and remove httptreemux (#382)
ed6d3f3 
- replace togo with go embed
- replace httptreemux with gin

closes #308
6543 pushed a commit to 6543-forks/woodpecker that referenced this issue Oct 27, 2021
@anbraten @6543
Use go embed for web files and remove httptreemux (woodpecker-ci#382)
df9e1f4 
- replace togo with go embed
- replace httptreemux with gin

closes woodpecker-ci#308
anbraten added a commit that referenced this issue Oct 28, 2021
@6543 @anbraten
Use go embed for web files and remove httptreemux (#382) (#489)
96155a4 
* Use go embed for web files and remove httptreemux (#382)

- replace togo with go embed
- replace httptreemux with gin

closes #308

* adapt

* ajust & cleanup

Co-authored-by: Anbraten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor delete or replace old code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use go embed for web files and remove httptreemux anbraten/woodpecker
1 participant
@6543