Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: multi-pipeline depends_on not working with custom config-path #270

Closed
anbraten opened this issue Aug 20, 2021 · 0 comments · Fixed by #280
Closed

Bug: multi-pipeline depends_on not working with custom config-path #270

anbraten opened this issue Aug 20, 2021 · 0 comments · Fixed by #280

Comments

@anbraten
Copy link
Member

anbraten commented Aug 20, 2021

If I use .woodpecker as config_path for my repo with two pipeline files:

# .test.yml

pipeline:
  test:
    image: golang:1.16
    group: test
    commands:
      - make formatcheck
# .release.yml

pipeline:
  release:
    image: ghcr.io/goreleaser/goreleaser:v0.174.1
    secrets: [github_token, docker_username, docker_password]
    commands:
      - goreleaser release
    when:
      event: [tag, push]
      branch: master

depends_on:
  - test
  # instead the following line would work
  # - "woodpecker/.test"

This comes from a bug inside the procBuilder not deleting the confiured config_path value.

If the name of the depends_on is not found, the job simply gets removed. For a better UX it could be a better solution to throw an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant