Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forges missing Support of functions #1138

Open
1 task
6543 opened this issue Aug 29, 2022 · 6 comments
Open
1 task

Forges missing Support of functions #1138

6543 opened this issue Aug 29, 2022 · 6 comments
Labels
enhancement improve existing features summary it's a summary for lot of issues

Comments

@6543
Copy link
Member

6543 commented Aug 29, 2022

admin permission check

  • ...

get pr file changes

@6543 6543 changed the title placeholder Forges Support Aug 29, 2022
@6543 6543 changed the title Forges Support Forges missing Support of functions Aug 29, 2022
@6543 6543 added summary it's a summary for lot of issues enhancement improve existing features labels Aug 29, 2022
@lafriks
Copy link
Contributor

lafriks commented Sep 2, 2022

There are also some forges missing org membership/org admin right check

@mzampetakis
Copy link
Contributor

Can this issue be revised after these merges:
#2045
#2011

That about the get pr file changes functionality?
Also the issue is mentioned at the docs: https://woodpecker-ci.org/docs/next/usage/workflows
and might need some revision.

@6543
Copy link
Member Author

6543 commented Aug 4, 2023

uh right the docs there also need adjustments ... pulls welcome

@mzampetakis
Copy link
Contributor

@6543 Is there any specific requirement for getting pr file changes for bitbucket or is this supported through basic forge's functionality (.e.g Dir(), BranchHead() etc)?

@6543
Copy link
Member Author

6543 commented Aug 6, 2023

It's just basic forge functionality

E.g.:

pipeline.ChangedFiles, err = c.getChangedFilesForPR(ctx, repo, index)

so in short, just alter the Hook() to set the pipeline.ChangedFiles field

@mzampetakis
Copy link
Contributor

Hmmm, it seems that bitbucket is still missing this functionality from https://github.com/woodpecker-ci/woodpecker/blob/main/server/forge/bitbucket/convert.go#L151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features summary it's a summary for lot of issues
Projects
None yet
Development

No branches or pull requests

3 participants