Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product Collection - use Product Title instead of core/post-title variation #42346

Closed
kmanijak opened this issue Jun 7, 2023 · 2 comments
Closed

Product Collection - use Product Title instead of core/post-title variation #42346

kmanijak opened this issue Jun 7, 2023 · 2 comments
Labels
block: product collection Issues related to the Product Collection block block-type: product elements Issues related to Product Element blocks. team: Kirigami & Origami WC Store Editing (FSE) type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@kmanijak
Copy link
Contributor

kmanijak commented Jun 7, 2023

Description

Currently Product Collection uses core/post-title variation as a Product Title block in the same manner as Products block did. That causes some problems with the new way of fetching data in the Product Collection block (woocommerce/woocommerce-blocks#9469) and also adds another Product Title block into inserter that's created for specific purpose.

Goal

Replace the variation with the Product Title from Product Elements
@kmanijak kmanijak added block-type: product elements Issues related to Product Element blocks. block: product collection Issues related to the Product Collection block labels Jun 7, 2023
This was referenced Dec 11, 2023
Closed
Closed
@nerrad nerrad added the team: Kirigami & Origami WC Store Editing (FSE) label Dec 1, 2023
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
@kmanijak kmanijak added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Dec 28, 2023
@kmanijak
Copy link
Contributor Author

kmanijak commented Mar 6, 2024

We don't plan to work on it atm. Closing it.

@kmanijak
Copy link
Contributor Author

kmanijak commented Mar 6, 2024

We're not planning to work on it atm. Hence I'm closing the issue. If necessary we'll open a new one reflecting on the current Product Collection block state.

@kmanijak kmanijak closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
block: product collection Issues related to the Product Collection block block-type: product elements Issues related to Product Element blocks. team: Kirigami & Origami WC Store Editing (FSE) type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Product Title in Product Collection block woocommerce/woocommerce-blocks
2 participants
@nerrad @kmanijak