This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add media controls to the Featured Category block #6360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
|
Size Change: +131 B (0%) Total Size: 872 kB
ℹ️ View Unchanged
|
|
@sunyatasattva I really like what you've done here, and the block works as expected based on the testing steps you've provided along with the warning. I am just wondering do we use similar controls on other blocks? The reason I ask is based on the conversation about the "Replace" button, and about this being a pattern. So I am wondering if this is also inline with how its done with other blocks in Gutenberg. If not, do you think it's worth Vivien having a look over this too? |
tjcafferkey
approved these changes
May 4, 2022
There was a problem hiding this comment.
Preemptively approving this but left a comment here #6360 (comment)
We don't use any other blocks with media controls AFAIK, but based on the Gutenberg image block, this is the current pattern. Although I'd always vote for some design UX revision to be honest, I don't find it a great experience currently. |
sunyatasattva
deleted the
feature/6236-featured-category-block-media-controls
branch
opr
added
type: enhancement
This was referenced Jul 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds image editing controls to the Featured Categort block. In particular, user can now:
Each edit gets saved in the database as a new image.
Closes #6236
Screenshots
Testing
Automated Tests
User Facing Testing
Zoom, Aspect ratio, Rotate | Apply, CancelcontrolsThe image editor UX might not be immediately intuitive, but it will make sense after a while when you'll familiarize. In the meantime, if you have never used that, you might be taken aback from the following things:
WooCommerce Visibility
Performance Impact
Changelog