This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add media controls to the Featured Product block #6348
Merged
sunyatasattva
merged 3 commits into
trunk
from
feature/6235-featured-product-media-controls
May 3, 2022
Merged
Add media controls to the Featured Product block #6348
sunyatasattva
merged 3 commits into
trunk
from
feature/6235-featured-product-media-controls
May 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
April 29, 2022 21:43
sunyatasattva
added
type: enhancement
The issue is a request for an enhancement.
focus: components
Work that introduces new or updates existing components.
block: featured product
Issues related to the Featured Product block.
labels
Apr 29, 2022
Size Change: +568 B (0%) Total Size: 871 kB
ℹ️ View Unchanged
|
dinhtungdu
approved these changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree the UX of the image editor is not intuitive, but the code is LGTM!
This was referenced Jul 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: featured product
Issues related to the Featured Product block.
focus: components
Work that introduces new or updates existing components.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds image editing controls to the Featured Product block. In particular, user can now:
Each edit gets saved in the database as a new image.
Closes #6235
Screenshots
Testing
Automated Tests
User Facing Testing
Zoom, Aspect ratio, Rotate | Apply, Cancel
controlsThe image editor UX might not be immediately intuitive, but it will make sense after a while when you'll familiarize. In the meantime, if you have never used that, you might be taken aback from the following things:
WooCommerce Visibility
Performance Impact
Changelog