This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix Featured Product block frontend mismatch #6263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Featured Product block was added but not modified at all, the block would not match the editor on the front end. This was due to the fact that, on the frontend, the block is SSR and was missing some defaults which were present in JS.
sunyatasattva
added
status: blocker
rubikuserbot
requested review from
a team and
albarin
and removed request for
a team
|
Size Change: 0 B Total Size: 863 kB ℹ️ View Unchanged
|
This was referenced Jul 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Featured Product block was added but not modified at all, the block would not match the editor on the front end.
This was due to the fact that, on the frontend, the block is SSR and was missing some defaults styles which were present in JS.
Fixes #6255
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
featured_block::default_heightsetting.User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Skipping changelog here as #6181 (which introduced the bug) was never published.