This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make Filters Products by Price work with Active Filters block
#6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
type: bug
rubikuserbot
requested review from
a team and
tomasztunik
and removed request for
a team
|
Size Change: +123 B (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
tjcafferkey
reviewed
Apr 13, 2022
tjcafferkey
reviewed
Apr 13, 2022
|
This tests well for me but will leave the final review for @tomasztunik seeing as I also worked on this PR 😄 |
tomasztunik
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Looks/works good 👌
Noticed differences as to how filtering is handled on /shop page vs custom built shop page with All Products block and filters added on the side. On /shop page there is full page reload and if user has scrolled view it would jump back to top and sometimes it would have the blocks reload asynchronously (or data fetch would cause placeholder to show up) while on the custom built page it works nice without any reloads or scroll jumps.
Active filters also works on All Products approach. It's not perfect there though as the URL params are not updated for the All Products variant.
Just sharing observations, not part of the issue!
(ps fixed conflicting file)
This was referenced Jul 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we render the PHP Classic template with the Filter Products by Price block we need to make sure the Active Filters block is also updated with the
min_priceandmax_pricevalues from the URL.Note: clicking on Clear All on the
Active Filtersblock won't actually clear the price on the slider. That's a known limitation of theActive Filtersblock and will be addressed on here: #6138Fixes #6243
Testing
Filter Products by Priceblock &Active Filtersblock to the Shop PageFilter Products by Priceblock, the page should reload with the filter params now being in the URL too.Active Filtersblock shows the active price filter.Changelog