This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tarhi-saad
and removed request for
a team
April 6, 2022 11:34
Size Change: -42 B (0%) Total Size: 874 kB
ℹ️ View Unchanged
|
tarhi-saad
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarunvijwani, thank you for the fix. The manual test was successful. And I only updated the comments to show the updated limit. Feel free to 🚢.
Nice catch. I forgot to update the comments. Thank you, @tarhi-saad! |
tarhi-saad
added
block: cart
Issues related to the cart block.
focus: blocks
Specific work involving or impacting how blocks behave.
type: bug
The issue/PR concerns a confirmed bug.
labels
Apr 11, 2022
tarhi-saad
changed the title
Increased Cart product quantity limit to 9999
Increase Cart product quantity limit
Apr 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: cart
Issues related to the cart block.
focus: blocks
Specific work involving or impacting how blocks behave.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While the quantities of items in the cart block can be changed, they cannot be set greater than 99.
Solution
With this PR, product quantity in the cart can be increased to 9999.
Fixes #6175
Screenshots
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
fix/product-quantity-limit
branchUser Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Performance Impact
Changelog