Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Increase Cart product quantity limit #6202

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Conversation

tarunvijwani
Copy link

@tarunvijwani tarunvijwani commented Apr 6, 2022

Issue

While the quantities of items in the cart block can be changed, they cannot be set greater than 99.

Solution

With this PR, product quantity in the cart can be increased to 9999.

Fixes #6175

Screenshots

Before After
image image

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

Manual Testing

How to test the changes in this Pull Request:

  1. Checkout the fix/product-quantity-limit branch
  2. Go to the shop page and add any product to the cart
  3. Go to the Cart block page and increase product quantity to 9999

User Facing Testing

These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).

  • Same as above, or

Performance Impact

Changelog

Increase Cart product quantity limit

@rubikuserbot rubikuserbot requested review from a team and tarhi-saad and removed request for a team April 6, 2022 11:34
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Size Change: -42 B (0%)

Total Size: 874 kB

Filename Size Change
build/cart-frontend.js 45.7 kB -2 B (0%)
build/checkout-frontend.js 48 kB -2 B (0%)
build/wc-blocks-editor-style-rtl.css 4.96 kB +19 B (0%)
build/wc-blocks-editor-style.css 4.96 kB +21 B (0%)
build/wc-blocks-style-rtl.css 21.9 kB -40 B (0%)
build/wc-blocks-style.css 21.9 kB -38 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 5.92 kB
build/active-filters.js 6.96 kB
build/all-products-frontend.js 18.2 kB
build/all-products.js 34 kB
build/all-reviews.js 8.01 kB
build/attribute-filter-frontend.js 16.9 kB
build/attribute-filter.js 13.1 kB
build/blocks-checkout.js 17.4 kB
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.17 kB
build/cart-blocks/cart-express-payment-frontend.js 5.2 kB
build/cart-blocks/cart-items-frontend.js 299 B
build/cart-blocks/cart-line-items-frontend.js 5.5 kB
build/cart-blocks/cart-order-summary-frontend.js 1.1 kB
build/cart-blocks/cart-totals-frontend.js 321 B
build/cart-blocks/empty-cart-frontend.js 344 B
build/cart-blocks/filled-cart-frontend.js 755 B
build/cart-blocks/order-summary-coupon-form-frontend.js 2.75 kB
build/cart-blocks/order-summary-discount-frontend.js 2.27 kB
build/cart-blocks/order-summary-fee-frontend.js 273 B
build/cart-blocks/order-summary-heading-frontend.js 452 B
build/cart-blocks/order-summary-shipping--checkout-blocks/order-summary-shipping-frontend.js 6.33 kB
build/cart-blocks/order-summary-shipping-frontend.js 428 B
build/cart-blocks/order-summary-subtotal-frontend.js 273 B
build/cart-blocks/order-summary-taxes-frontend.js 433 B
build/cart-blocks/proceed-to-checkout-frontend.js 1.15 kB
build/cart.js 44.5 kB
build/checkout-blocks/actions-frontend.js 1.41 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.12 kB
build/checkout-blocks/billing-address-frontend.js 893 B
build/checkout-blocks/contact-information-frontend.js 2.83 kB
build/checkout-blocks/express-payment-frontend.js 5.49 kB
build/checkout-blocks/fields-frontend.js 344 B
build/checkout-blocks/order-note-frontend.js 1.08 kB
build/checkout-blocks/order-summary-cart-items-frontend.js 3.65 kB
build/checkout-blocks/order-summary-coupon-form-frontend.js 2.9 kB
build/checkout-blocks/order-summary-discount-frontend.js 2.39 kB
build/checkout-blocks/order-summary-fee-frontend.js 275 B
build/checkout-blocks/order-summary-frontend.js 1.1 kB
build/checkout-blocks/order-summary-shipping-frontend.js 604 B
build/checkout-blocks/order-summary-subtotal-frontend.js 273 B
build/checkout-blocks/order-summary-taxes-frontend.js 433 B
build/checkout-blocks/payment-frontend.js 7.77 kB
build/checkout-blocks/shipping-address-frontend.js 997 B
build/checkout-blocks/shipping-methods-frontend.js 4.72 kB
build/checkout-blocks/terms-frontend.js 1.22 kB
build/checkout-blocks/totals-frontend.js 325 B
build/checkout.js 45.8 kB
build/featured-category.js 8.66 kB
build/featured-product.js 9.78 kB
build/handpicked-products.js 7.13 kB
build/legacy-template.js 2.19 kB
build/mini-cart-component-frontend.js 16.5 kB
build/mini-cart-contents-block/empty-cart-frontend.js 326 B
build/mini-cart-contents-block/filled-cart-frontend.js 229 B
build/mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 5.32 kB
build/mini-cart-contents-block/footer-frontend.js 5.62 kB
build/mini-cart-contents-block/items-frontend.js 226 B
build/mini-cart-contents-block/products-table-frontend.js 5.36 kB
build/mini-cart-contents-block/shopping-button-frontend.js 287 B
build/mini-cart-contents-block/title-frontend.js 367 B
build/mini-cart-contents.js 23.4 kB
build/mini-cart-frontend.js 1.71 kB
build/mini-cart.js 6.57 kB
build/price-filter-frontend.js 12.3 kB
build/price-filter.js 8.72 kB
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js 223 B
build/product-add-to-cart--product-button--product-image--product-title.js 2.64 kB
build/product-add-to-cart-frontend.js 7 kB
build/product-add-to-cart.js 7.48 kB
build/product-best-sellers.js 7.4 kB
build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js 500 B
build/product-button-frontend.js 2.07 kB
build/product-button.js 2.29 kB
build/product-categories.js 3.16 kB
build/product-category-list-frontend.js 922 B
build/product-category-list.js 501 B
build/product-category.js 8.5 kB
build/product-image-frontend.js 1.84 kB
build/product-image.js 1.07 kB
build/product-new.js 7.68 kB
build/product-on-sale.js 7.99 kB
build/product-price-frontend.js 1.93 kB
build/product-price.js 1.5 kB
build/product-rating-frontend.js 1.15 kB
build/product-rating.js 735 B
build/product-sale-badge-frontend.js 1.09 kB
build/product-sale-badge.js 678 B
build/product-search.js 2.18 kB
build/product-sku-frontend.js 380 B
build/product-sku.js 381 B
build/product-stock-indicator-frontend.js 1.03 kB
build/product-stock-indicator.js 621 B
build/product-summary-frontend.js 1.33 kB
build/product-summary.js 918 B
build/product-tag-list-frontend.js 916 B
build/product-tag-list.js 495 B
build/product-tag.js 7.83 kB
build/product-title-frontend.js 1.29 kB
build/product-title.js 911 B
build/product-top-rated.js 7.92 kB
build/products-by-attribute.js 8.41 kB
build/reviews-by-category.js 11.5 kB
build/reviews-by-product.js 12.6 kB
build/reviews-frontend.js 6.98 kB
build/single-product-frontend.js 21.6 kB
build/single-product.js 10.1 kB
build/stock-filter-frontend.js 6.51 kB
build/stock-filter.js 6.57 kB
build/vendors--cart-blocks/cart-line-items--cart-blocks/cart-order-summary--cart-blocks/order-summary-shi--c02aad66-frontend.js 5.26 kB
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js 3.14 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js 4.74 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--decc3dc6-frontend.js 20.5 kB
build/vendors--mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 7.35 kB
build/vendors--product-add-to-cart-frontend.js 7.53 kB
build/wc-blocks-data.js 9.83 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 930 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-blocks-vendors.js 71.4 kB
build/wc-blocks.js 2.62 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.61 kB

compressed-size-action

Copy link
Contributor

@tarhi-saad tarhi-saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarunvijwani, thank you for the fix. The manual test was successful. And I only updated the comments to show the updated limit. Feel free to 🚢.

@github-actions github-actions bot added this to the 7.4.0 milestone Apr 8, 2022
@tarunvijwani
Copy link
Author

Nice catch. I forgot to update the comments. Thank you, @tarhi-saad!

@tarunvijwani tarunvijwani merged commit da9a0fb into trunk Apr 8, 2022
@tarunvijwani tarunvijwani deleted the fix/product-quantity-limit branch April 8, 2022 08:46
@tarhi-saad tarhi-saad added block: cart Issues related to the cart block. focus: blocks Specific work involving or impacting how blocks behave. type: bug The issue/PR concerns a confirmed bug. labels Apr 11, 2022
@tarhi-saad tarhi-saad changed the title Increased Cart product quantity limit to 9999 Increase Cart product quantity limit Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. focus: blocks Specific work involving or impacting how blocks behave. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In-Cart Product Quantity Limited to 99
2 participants