Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Rename templates to more e-commerce friendly names #5935

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Rename templates to more e-commerce friendly names #5935

merged 3 commits into from
Feb 28, 2022

Conversation

sunyatasattva
Copy link
Contributor

@sunyatasattva sunyatasattva commented Feb 23, 2022 •
edited by frontdevde
Loading

It was suggested that we change the names of our templates to better reflect the user/merchant understanding of their store experience. Names like “archive” are associated with blogging/press and definitely not with products, so this PR addresses that.

Fixes #5891

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

Manual Testing

How to test the changes in this Pull Request:

  1. Open the site editor
  2. Ascertain that template names appear on the list according to the following table:
Old Title New Title
Product Archive Product Catalog
Product Tag Products by Tag
Product Category Products by Category
Single Product no change

Changelog

Renamed WooCommerce block templates to more e-commerce related names

@rubikuserbot rubikuserbot requested review from a team and frontdevde and removed request for a team February 23, 2022 20:27
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2022 •
edited
Loading

Size Change: +48.2 kB (+6%) 🔍

Total Size: 864 kB

Filename Size Change
build/active-filters-frontend.js 6.27 kB +4 B (0%)
build/active-filters.js 6.94 kB -6 B (0%)
build/all-products-frontend.js 18.6 kB +7 B (0%)
build/all-products.js 34.4 kB +138 B (0%)
build/all-reviews.js 8.03 kB -38 B (0%)
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/catego--214e300a.js 222 B +70 B (+46%) 🚨
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.65 kB -3 B (0%)
build/atomic-block-components/add-to-cart--atomic-block-components/category-list--atomic-block-components--68f6c1c4.js 0 B -203 B (removed) 🏆
build/atomic-block-components/add-to-cart-frontend.js 7.01 kB -4 B (0%)
build/atomic-block-components/add-to-cart.js 7.49 kB -7 B (0%)
build/atomic-block-components/button-frontend.js 2.08 kB +545 B (+36%) 🚨
build/atomic-block-components/button.js 2.3 kB +150 B (+7%) 🔍
build/atomic-block-components/category-list--atomic-block-components/image--atomic-block-components/ratin--2614069e.js 0 B -498 B (removed) 🏆
build/atomic-block-components/category-list-frontend.js 920 B -2 B (0%)
build/atomic-block-components/image-frontend.js 1.86 kB +1 B (0%)
build/atomic-block-components/image.js 1.09 kB -399 B (-27%) 🎉
build/atomic-block-components/price.js 1.69 kB -8 B (0%)
build/atomic-block-components/sale-badge.js 684 B -2 B (0%)
build/atomic-block-components/sku-frontend.js 385 B -1 B (0%)
build/atomic-block-components/sku.js 386 B +1 B (0%)
build/atomic-block-components/stock-indicator-frontend.js 1.03 kB -4 B (0%)
build/atomic-block-components/stock-indicator.js 625 B +1 B (0%)
build/atomic-block-components/summary-frontend.js 1.34 kB -1 B (0%)
build/atomic-block-components/summary.js 923 B -1 B (0%)
build/atomic-block-components/tag-list-frontend.js 921 B -1 B (0%)
build/atomic-block-components/title-frontend.js 1.31 kB +5 B (0%)
build/attribute-filter-frontend.js 16.8 kB -1 B (0%)
build/attribute-filter.js 13 kB -39 B (0%)
build/cart-blocks/accepted-payment-methods-frontend.js 1.14 kB -1 B (0%)
build/cart-blocks/checkout-button-frontend.js 1.15 kB -1 B (0%)
build/cart-blocks/empty-cart-frontend.js 347 B +1 B (0%)
build/cart-blocks/express-payment-frontend.js 5.18 kB -6 B (0%)
build/cart-blocks/filled-cart-frontend.js 767 B +2 B (0%)
build/cart-blocks/line-items-frontend.js 5.5 kB -9 B (0%)
build/cart-blocks/order-summary-frontend.js 8.88 kB -1 B (0%)
build/cart-frontend.js 45.2 kB -17 B (0%)
build/cart.js 43.5 kB +71 B (0%)
build/checkout-blocks/actions-frontend.js 1.41 kB +2 B (0%)
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.13 kB +4 B (0%)
build/checkout-blocks/billing-address-frontend.js 891 B +1 B (0%)
build/checkout-blocks/contact-information-frontend.js 2.85 kB +7 B (0%)
build/checkout-blocks/express-payment-frontend.js 5.48 kB +2 B (0%)
build/checkout-blocks/fields-frontend.js 344 B +1 B (0%)
build/checkout-blocks/order-summary-frontend.js 11.3 kB -25 B (0%)
build/checkout-blocks/payment-frontend.js 7.77 kB +3 B (0%)
build/checkout-blocks/shipping-methods-frontend.js 4.73 kB +4 B (0%)
build/checkout-blocks/terms-frontend.js 1.22 kB +1 B (0%)
build/checkout-frontend.js 47.4 kB +45 B (0%)
build/checkout.js 44.7 kB -167 B (0%)
build/featured-product.js 9.73 kB +11 B (0%)
build/handpicked-products.js 7.1 kB +1 B (0%)
build/legacy-template.js 2.18 kB -2 B (0%)
build/mini-cart-component-frontend.js 16 kB +1.73 kB (+12%) ⚠️
build/mini-cart-contents.js 24.2 kB +20.4 kB (+533%) 🆘
build/mini-cart.js 6.39 kB -6 B (0%)
build/price-filter-frontend.js 12.5 kB -3 B (0%)
build/price-filter.js 8.47 kB -4 B (0%)
build/product-best-sellers.js 7.37 kB +5 B (0%)
build/product-categories.js 3.17 kB +6 B (0%)
build/product-category.js 8.49 kB +1 B (0%)
build/product-new.js 7.67 kB -1 B (0%)
build/product-search.js 2.19 kB +1 B (0%)
build/product-tag.js 7.81 kB +5 B (0%)
build/product-top-rated.js 7.9 kB +1 B (0%)
build/products-by-attribute.js 8.38 kB -1 B (0%)
build/reviews-by-category.js 11.4 kB -74 B (-1%)
build/reviews-by-product.js 12.6 kB -33 B (0%)
build/reviews-frontend.js 7.34 kB +5 B (0%)
build/single-product-frontend.js 22 kB -42 B (0%)
build/single-product.js 10 kB -32 B (0%)
build/stock-filter-frontend.js 6.5 kB +3 B (0%)
build/stock-filter.js 6.56 kB -11 B (0%)
build/vendors--atomic-block-components/add-to-cart--cart-blocks/order-summary--checkout-blocks/billing-ad--c5eb4dcd-frontend.js 19 kB -5 B (0%)
build/vendors--atomic-block-components/price--cart-blocks/line-items--cart-blocks/order-summary--checkout--8a3571de-frontend.js 0 B -5.26 kB (removed) 🏆
build/vendors--cart-blocks/line-items--checkout-blocks/order-summary-frontend.js 0 B -3.14 kB (removed) 🏆
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---eb4d2cec-frontend.js 4.74 kB -1 B (0%)
build/wc-blocks-editor-style.css 4.84 kB -1 B (0%)
build/wc-blocks-style-rtl.css 22.2 kB +16 B (0%)
build/wc-blocks-style.css 22.2 kB +16 B (0%)
build/wc-blocks-vendors.js 69.4 kB +58 B (0%)
build/wc-blocks.js 2.62 kB +3 B (0%)
build/atomic-block-components/button--atomic-block-components/category-list--atomic-block-components/imag--acd4dc5e.js 500 B +500 B (new file) 🆕
build/mini-cart-contents-block/empty-cart-frontend.js 363 B +363 B (new file) 🆕
build/mini-cart-contents-block/filled-cart-frontend.js 222 B +222 B (new file) 🆕
build/mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 5.33 kB +5.33 kB (new file) 🆕
build/mini-cart-contents-block/footer-frontend.js 6.27 kB +6.27 kB (new file) 🆕
build/mini-cart-contents-block/items-frontend.js 206 B +206 B (new file) 🆕
build/mini-cart-contents-block/products-table-frontend.js 5.33 kB +5.33 kB (new file) 🆕
build/mini-cart-contents-block/shopping-button-frontend.js 260 B +260 B (new file) 🆕
build/mini-cart-contents-block/title-frontend.js 348 B +348 B (new file) 🆕
build/vendors--atomic-block-components/price--cart-blocks/line-items--cart-blocks/order-summary--checkout--194c50bf-frontend.js 5.26 kB +5.26 kB (new file) 🆕
build/vendors--cart-blocks/line-items--checkout-blocks/order-summary--mini-cart-contents-block/products-table-frontend.js 3.14 kB +3.14 kB (new file) 🆕
build/vendors--mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 7.72 kB +7.72 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
build/atomic-block-components/category-list.js 501 B
build/atomic-block-components/price-frontend.js 1.74 kB
build/atomic-block-components/rating-frontend.js 1.13 kB
build/atomic-block-components/rating.js 719 B
build/atomic-block-components/sale-badge-frontend.js 1.09 kB
build/atomic-block-components/tag-list.js 499 B
build/atomic-block-components/title.js 933 B
build/blocks-checkout.js 17.2 kB
build/cart-blocks/items-frontend.js 299 B
build/cart-blocks/totals-frontend.js 320 B
build/checkout-blocks/order-note-frontend.js 1.13 kB
build/checkout-blocks/shipping-address-frontend.js 997 B
build/checkout-blocks/totals-frontend.js 323 B
build/featured-category.js 8.62 kB
build/mini-cart-frontend.js 1.71 kB
build/price-format.js 1.19 kB
build/product-on-sale.js 7.99 kB
build/vendors--atomic-block-components/add-to-cart-frontend.js 7.51 kB
build/wc-blocks-data.js 9.78 kB
build/wc-blocks-editor-style-rtl.css 4.84 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 953 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.61 kB

compressed-size-action

@sunyatasattva sunyatasattva mentioned this pull request Feb 24, 2022
Closed
@sunyatasattva sunyatasattva marked this pull request as ready for review February 24, 2022 10:34
Aljullu
Aljullu approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating these names @sunyatasattva!

Given that this will affect the documentation we are working on, I will mark it as a blocker of the next release.

tests/e2e/specs/frontend/legacy-template-blocks.test.js Outdated Show resolved Hide resolved
@github-actions github-actions bot modified the milestone: 7.1.0 Feb 25, 2022
@Aljullu Aljullu added status: blocker Used on issues or pulls that block work from being released. focus: template Related to API powering block template functionality in the Site Editor and removed status: ready to merge labels Feb 25, 2022
@sunyatasattva @Aljullu
Fix typo in describe block
3a4c210 
Co-authored-by: Albert Juhé Lluveras <[email protected]>
@sunyatasattva sunyatasattva merged commit cd7cb5f into trunk Feb 28, 2022
@sunyatasattva sunyatasattva deleted the chore/5891-rename-templates-names branch February 28, 2022 07:00
@frontdevde frontdevde added the type: enhancement The issue is a request for an enhancement. label Feb 28, 2022
@frontdevde frontdevde mentioned this pull request Mar 7, 2022
Closed
@sunyatasattva sunyatasattva mentioned this pull request Mar 8, 2022
Closed
@mikejolley mikejolley mentioned this pull request Mar 15, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Aljullu Aljullu Aljullu approved these changes

@frontdevde frontdevde Awaiting requested review from frontdevde frontdevde was automatically assigned from woocommerce/woo-fse

Assignees

@sunyatasattva sunyatasattva

Labels
focus: template Related to API powering block template functionality in the Site Editor status: blocker Used on issues or pulls that block work from being released. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

Update WooCommerce templates names
3 participants
@sunyatasattva @Aljullu @frontdevde