This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add to cart button ignored redirect to cart setting #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the time being we expose only what is used by the blocks which is `cartRedirectAfterAdd`. In the future more can be added as needed. Setting is accessible via `getSetting( 'productsSettings' )`. We namespace the settings under productsSettigns to reflect the domain and how settings are organised in Woo admin and to inform that this is an object with more settings within. This setting normally was available **only** if AJAX add to cart was set as a js global `wc_add_to_cart_params.cart_redirect_after_add`. By accessing the option directly we ensure it’s exposed to blocks regardless of if AJAX option is enabled.
This adds the redirect directly on the AddToCartButton after succesful add to cart action. This follows convention that redirects or other side effects shouldn’t happen as part of the action but rather be part of the control that triggers such flow.
rubikuserbot
requested review from
a team and
sunyatasattva
and removed request for
a team
|
I've explored hooking it up in (And thanks @opr for the support and pointers!) |
|
Size Change: +178 B (0%) Total Size: 811 kB
ℹ️ View Unchanged
|
sunyatasattva
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Great job. I love the well-thought-through PR description with all your thoughts and all that was done, and the comments in the code.
I'm just wondering… are we (or Gutenberg) not using any form of router? Redirecting via hard-coding the window.location.href feels a bit crude.
But if we don't have any routing set up, then no problem!
|
Was curious about it as well when working on this @sunyatasattva. Woo is not a SPA and out of the box it doesn't have any routers or custom history handler contexts it seems. WooCommerce extension where it does redirect does it this way as well. |
tomasztunik
deleted the
fix/1766-add-to-cart-button-ignored-redirect-to-cart
branch
sunyatasattva
added
focus: blocks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue where All Products (and all other blocks) where Add to Cart button was present were ignoring the Redirect to Cart after item added setting was enabled.
We expose WooCommerce products settings in
wcSettingsFor the time being we expose only what is used by the blocks
which is
cartRedirectAfterAdd. In the future more can be addedas needed. Setting is accessible via
getSetting( 'productsSettings' ).We namespace the settings under productsSettigns to reflect
the domain and how settings are organised in Woo admin and to
inform that this is an object with more settings within.
This setting normally was available only if AJAX add to cart was set
as a JS global
wc_add_to_cart_params.cart_redirect_after_add.By accessing the option directly we ensure it’s exposed
to blocks regardless of if AJAX option is enabled.
This adds the redirect directly on the AddToCartButton after successful
add to cart action and it follows convention that redirects or other side
effects shouldn’t happen as part of the action but rather be part of the
control that triggers such flow.
Fixes #1766
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog