This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix Twenty Twenty-Two Products by Category block item tile styling issues #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
sunyatasattva
and removed request for
a team
|
Size Change: +59 B (0%) Total Size: 745 kB
ℹ️ View Unchanged
|
tomasztunik
changed the title
tomasztunik
changed the title
sunyatasattva
approved these changes
Feb 2, 2022
|
Not yet @sunyatasattva! Got this and couple other little things I'm wrapping up to share as my onboarding summary/outcome. |
tomasztunik
deleted the
fix/5285-and-5286-twentytwentytwo-prodcut-list-tile-style-issues
branch
sunyatasattva
added
focus: global styles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides override styles for the Twenty Twenty Two theme to correctly display added to cart "View cart" call out (#5285) and sale prices to not be underlined (#5286).
This follows convention from the past where core themes were receiving patches in styles.scss via theme class namespace.
I've merged these two issues as they were very closely related and trivial in their complexity and the little potential effect on other areas of the extension.
Fixes #5285
Fixes #5286
Screenshots
On mobile:
On desktop:
Testing
Manual Testing
How to test the changes in this Pull Request:
View cartaction is centred under theAdd to cartbutton and not broken into two linesUser Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog