This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Convert token to string when setting the active payment method #5535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralucaStan
added
type: bug
The issue/PR concerns a confirmed bug.
block: checkout
Issues related to the checkout block.
priority: high
The issue/PR is high priority—it affects lots of customers substantially, but not critically.
labels
Jan 7, 2022
Size Change: -2 B (0%) Total Size: 819 kB
ℹ️ View Unchanged
|
opr
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests out fine, thanks Raluca :)
ralucaStan
changed the title
Force a string token property for the activePaymentMethod
Convert token to string when setting the active payment method
Jan 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: checkout
Issues related to the checkout block.
priority: high
The issue/PR is high priority—it affects lots of customers substantially, but not critically.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cards saved during the checkout process, the payment_data token is being put through as an integer since 6.6.0 because of the changes introduced by this PR
This PR fixes this issue by converting the token to string when dispatching the setActivePaymentMethod.
Fixes #5522
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
Save payment information to my account for future purchases.
payment_data[0] [value] is not of type string.boolean.
error is showed.User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Additionally perform a quick smoke test to the Checkout block:
Changelog