This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add margin below shipping packages in checkout #5529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
focus: blocks
Specific work involving or impacting how blocks behave.
focus: global styles
Issues that involve styles/css/layout structure.
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
block: checkout
Issues related to the checkout block.
labels
Jan 6, 2022
rubikuserbot
requested review from
a team and
alexflorisca
and removed request for
a team
January 6, 2022 17:13
Size Change: +302 B (0%) Total Size: 820 kB
ℹ️ View Unchanged
|
alexflorisca
suggested changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, cheers for the review, I've updated it now :) |
alexflorisca
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, looks good!
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: checkout
Issues related to the checkout block.
focus: blocks
Specific work involving or impacting how blocks behave.
focus: global styles
Issues that involve styles/css/layout structure.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds margin below the
wc-block-components-shipping-rates-control__package
class, but not on the last of type to prevent this from affecting the parent component's spacing.Fixes #5279
Screenshots
Testing
Automated Tests
Manual Testing
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog