This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Mini Cart Block: The color of the badge reflects the global style #5477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mini Cart Block: the color of the badge reflects the global style #4965
gigitux
added
skip-changelog
PRs that you don't want to appear in the changelog.
focus: global styles
Issues that involve styles/css/layout structure.
focus: FSE
Work related to prepare WooCommerce for FSE.
block: mini-cart
Issues related to the Mini-Cart block.
labels
Jan 3, 2022
rubikuserbot
requested review from
a team and
sunyatasattva
and removed request for
a team
January 3, 2022 11:41
Size Change: +1 B (0%) Total Size: 819 kB
ℹ️ View Unchanged
|
18 tasks
sunyatasattva
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gigitux @Aljullu with this PR, the Mini Cart button doesn't work well for dark themes. The background setting was added to set the background color of the button as well as the badge. We used |
Sorry I'm very late on this. 🙂 I'm right assuming this was fixed in #5539 or is there anything that needs to be done? @gigitux @dinhtungdu |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: mini-cart
Issues related to the Mini-Cart block.
focus: FSE
Work related to prepare WooCommerce for FSE.
focus: global styles
Issues that involve styles/css/layout structure.
skip-changelog
PRs that you don't want to appear in the changelog.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the color of the badge of Mini Cart Block will reflect the global style.
This PR also disables the ability to customize the background because it shouldn't be possible.
Fixes #4965
Screenshots
before this PR
with this PR
Manual Testing
How to test the changes in this PR:
Check out this branch:
Gutenberg
plugin.TT1 Blocks
theme.Mini Cart Block
.Mini Cart Block
is shown and you can tweak its styles.