Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix extra network request on cart #5394

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Fix extra network request on cart #5394

merged 1 commit into from
Dec 16, 2021

Conversation

alexflorisca
Copy link
Member

@alexflorisca alexflorisca commented Dec 15, 2021 •
edited by mikejolley
Loading

PR5129 introduced an extra unnecessary network request to update customer data when the cart is mounted. Initially, the local state customerData was out of sync with the cart store. The code removed in this PR was added in the previous PR to keep the local state and the cart in sync. While this would still be nice, it's not necessary and introduces an extra network request.

Manual Testing

How to test the changes in this Pull Request:

  1. Load the cart page
  2. There should be no requests (batch or otherwise) to update customer data once the cart is mounted

Changelog

Fixed a performance issue with the cart by preventing an extra network request on mount.

@alexflorisca alexflorisca self-assigned this Dec 15, 2021
@alexflorisca alexflorisca requested a review from senadir December 15, 2021 18:32
@alexflorisca alexflorisca added focus: components Work that introduces new or updates existing components. type: bug The issue/PR concerns a confirmed bug. block: cart Issues related to the cart block. labels Dec 15, 2021
@rubikuserbot rubikuserbot requested a review from a team December 15, 2021 18:35
@github-actions
Copy link
Contributor

Size Change: -127 B (0%)

Total Size: 819 kB

Filename Size Change
build/cart-frontend.js 45.5 kB -29 B (0%)
build/cart.js 44.4 kB -31 B (0%)
build/checkout-frontend.js 47.6 kB -36 B (0%)
build/checkout.js 47.1 kB -31 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 6.22 kB
build/active-filters.js 7.05 kB
build/all-products-frontend.js 18.6 kB
build/all-products.js 34.4 kB
build/all-reviews.js 8.35 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.76 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.48 kB
build/atomic-block-components/add-to-cart-frontend.js 6.87 kB
build/atomic-block-components/add-to-cart.js 6.42 kB
build/atomic-block-components/button-frontend.js 1.48 kB
build/atomic-block-components/button.js 851 B
build/atomic-block-components/category-list-frontend.js 457 B
build/atomic-block-components/category-list.js 458 B
build/atomic-block-components/image-frontend.js 1.37 kB
build/atomic-block-components/image.js 1.05 kB
build/atomic-block-components/price-frontend.js 1.74 kB
build/atomic-block-components/price.js 1.7 kB
build/atomic-block-components/rating-frontend.js 552 B
build/atomic-block-components/rating.js 554 B
build/atomic-block-components/sale-badge-frontend.js 625 B
build/atomic-block-components/sale-badge.js 622 B
build/atomic-block-components/sku-frontend.js 386 B
build/atomic-block-components/sku.js 385 B
build/atomic-block-components/stock-indicator-frontend.js 584 B
build/atomic-block-components/stock-indicator.js 585 B
build/atomic-block-components/summary-frontend.js 872 B
build/atomic-block-components/summary.js 871 B
build/atomic-block-components/tag-list-frontend.js 458 B
build/atomic-block-components/tag-list.js 458 B
build/atomic-block-components/title-frontend.js 1.11 kB
build/atomic-block-components/title.js 1.1 kB
build/attribute-filter-frontend.js 16.3 kB
build/attribute-filter.js 12.7 kB
build/blocks-checkout.js 17.6 kB
build/cart-blocks/accepted-payment-methods-frontend.js 1.15 kB
build/cart-blocks/checkout-button-frontend.js 1.14 kB
build/cart-blocks/empty-cart-frontend.js 345 B
build/cart-blocks/express-payment-frontend.js 4.86 kB
build/cart-blocks/filled-cart-frontend.js 766 B
build/cart-blocks/items-frontend.js 298 B
build/cart-blocks/line-items-frontend.js 5.13 kB
build/cart-blocks/order-summary-frontend.js 8.97 kB
build/cart-blocks/totals-frontend.js 320 B
build/checkout-blocks/actions-frontend.js 1.44 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.24 kB
build/checkout-blocks/billing-address-frontend.js 884 B
build/checkout-blocks/contact-information-frontend.js 2.95 kB
build/checkout-blocks/express-payment-frontend.js 5.15 kB
build/checkout-blocks/fields-frontend.js 343 B
build/checkout-blocks/order-note-frontend.js 1.13 kB
build/checkout-blocks/order-summary-frontend.js 11.4 kB
build/checkout-blocks/payment-frontend.js 7.41 kB
build/checkout-blocks/shipping-address-frontend.js 971 B
build/checkout-blocks/shipping-methods-frontend.js 4.81 kB
build/checkout-blocks/terms-frontend.js 1.21 kB
build/checkout-blocks/totals-frontend.js 324 B
build/featured-category.js 8.55 kB
build/featured-product.js 9.9 kB
build/handpicked-products.js 7.32 kB
build/legacy-template.js 2.08 kB
build/mini-cart-component-frontend.js 14.2 kB
build/mini-cart-contents.js 3.58 kB
build/mini-cart-frontend.js 1.76 kB
build/mini-cart.js 6.45 kB
build/price-filter-frontend.js 12.4 kB
build/price-filter.js 8.61 kB
build/price-format.js 1.18 kB
build/product-best-sellers.js 7.51 kB
build/product-categories.js 3.47 kB
build/product-category.js 8.35 kB
build/product-new.js 7.66 kB
build/product-on-sale.js 8.05 kB
build/product-search.js 2.47 kB
build/product-tag.js 7.76 kB
build/product-top-rated.js 7.63 kB
build/products-by-attribute.js 8.48 kB
build/reviews-by-category.js 11.9 kB
build/reviews-by-product.js 12.9 kB
build/reviews-frontend.js 7.25 kB
build/single-product-frontend.js 22.1 kB
build/single-product.js 10.4 kB
build/stock-filter-frontend.js 6.81 kB
build/stock-filter.js 6.82 kB
build/vendors--atomic-block-components/add-to-cart--cart-blocks/order-summary--checkout-blocks/billing-ad--c5eb4dcd-frontend.js 19 kB
build/vendors--atomic-block-components/add-to-cart-frontend.js 6.82 kB
build/vendors--atomic-block-components/price--cart-blocks/line-items--cart-blocks/order-summary--checkout--8a3571de-frontend.js 5.71 kB
build/vendors--cart-blocks/line-items--checkout-blocks/order-summary-frontend.js 3.14 kB
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---eb4d2cec-frontend.js 4.75 kB
build/wc-blocks-data.js 8.84 kB
build/wc-blocks-editor-style-rtl.css 4.4 kB
build/wc-blocks-editor-style.css 4.4 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 949 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.51 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-style-rtl.css 21.6 kB
build/wc-blocks-style.css 21.6 kB
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-blocks-vendors.js 65.5 kB
build/wc-blocks.js 2.96 kB
build/wc-payment-method-bacs.js 820 B
build/wc-payment-method-cheque.js 816 B
build/wc-payment-method-cod.js 912 B
build/wc-payment-method-paypal.js 838 B
build/wc-payment-method-stripe.js 11.1 kB
build/wc-settings.js 2.61 kB

compressed-size-action

@alexflorisca alexflorisca requested a review from opr December 16, 2021 09:51
opr
opr approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me and I've confirmed there's no regression for #5070

🚢 it!

@github-actions github-actions bot added this to the 6.6.0 milestone Dec 16, 2021
@alexflorisca alexflorisca merged commit 83df20b into trunk Dec 16, 2021
@alexflorisca alexflorisca deleted the fix/update-customer-data branch December 16, 2021 10:30
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this pull request Dec 16, 2021
@alexflorisca @jonny-bull
Fix extra network request on cart (woocommerce#5394)
ae86baf
@mikejolley mikejolley added the focus: performance The issue/PR is related to performance. label Dec 20, 2021
@opr opr mentioned this pull request Dec 23, 2021
Closed
@mikejolley
Copy link
Member

This PR seems to have regressed the population of the address fields on the first mount (see #5456 (comment)). I'm investigating now.

@mikejolley mikejolley mentioned this pull request Dec 30, 2021
Merged
@ralucaStan ralucaStan mentioned this pull request Jan 4, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@opr opr opr approved these changes

@senadir senadir Awaiting requested review from senadir

Assignees

@alexflorisca alexflorisca

Labels
block: cart Issues related to the cart block. focus: components Work that introduces new or updates existing components. focus: performance The issue/PR is related to performance. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alexflorisca @mikejolley @opr