This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add error message for fetch errors on checkout #5341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
ralucaStan
and removed request for
a team
mikejolley
added
status: needs review
type: bug
|
Size Change: -21.8 kB (-3%) Total Size: 819 kB
ℹ️ View Unchanged
|
ralucaStan
reviewed
Dec 9, 2021
| let errorNotice = sprintf( | ||
| // Translators: %s Error text. | ||
| __( | ||
| 'Error: %s Please try placing your order again.', |
There was a problem hiding this comment.
How about Order could not be placed. %s Please try placing your order again. instead of Error: %s Please try placing your order again..
There was a problem hiding this comment.
@ralucaStan Updated to 'Something went wrong. %s Please try placing your order again.' to match other notices.
| dispatchActions.setAfterProcessing( response ); | ||
| setIsProcessingOrder( false ); | ||
| } ); | ||
| errorNotice = formatStoreApiErrorMessage( response ); |
There was a problem hiding this comment.
I don't understand the reason behind declaring errorNotice and replacing it here. What changes?
There was a problem hiding this comment.
Just to avoid calling addErrorNotice in multiple places. it's done at the end.
|
I've tested and the offline error is showed as expected but I think the PR introduces a bug: when going to the Checkout block and entering invalid zip code I used to see this error: |
|
The testing steps did not work for me. Placing an order without an address does not call the /checkout endpoint, because a front-end validation appears. I've tested introducing an invalid zip (Germany, 100000000). |
ralucaStan
reviewed
Dec 10, 2021
|
@ralucaStan can you try now? I think it was the |
ralucaStan
approved these changes
Dec 13, 2021
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Add error message for fetch errors on checkout * Update message text * revert gitignore change * Remove errorNotice variable
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Add error message for fetch errors on checkout * Update message text * revert gitignore change * Remove errorNotice variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds handling for network errors during the request to
/wc/store/checkout. Currently it handles API errors (4xx/5xx) but does not factor in other errors like failed requests and offline browsers.Fixes #4894
Screenshots
In offline mode, this is now shown:
Testing
How to test the changes in this Pull Request:
User Facing Testing
Changelog