This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Rest API - Namespace error handling #5319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
nielslange
and removed request for
a team
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* get_routes_from_namespace needs to handle WP_Error responses * is_request_to_store_api is not static
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* get_routes_from_namespace needs to handle WP_Error responses * is_request_to_store_api is not static
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents an error calling
get_data()on the wrong object, if a WP_Error object is returned for whatever reason e.g. the endpoints not being registered.Also fixes warnings from returned types.
Fixes #4683
Testing
This error is not reproducible without 3rd party code. I forced an error by swapping the
wc/storewhen calling the function to something invalid to ensure no fatal error occurred. Nothing a user can test here.Changelog