This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Remove full-width mode from cart and checkout block #5315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: bug
The issue/PR concerns a confirmed bug.
block: cart
Issues related to the cart block.
block: checkout
Issues related to the checkout block.
priority: low
The issue/PR is low priority—not many people are affected or there’s a workaround, etc.
labels
Dec 6, 2021
rubikuserbot
requested review from
a team and
alexflorisca
and removed request for
a team
December 6, 2021 09:43
Size Change: -17 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
alexflorisca
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested for both filled and empty cart and the "full width" option is not there any longer 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: cart
Issues related to the cart block.
block: checkout
Issues related to the checkout block.
priority: low
The issue/PR is low priority—not many people are affected or there’s a workaround, etc.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5010
Until now, it was possible to show the cart and the checkout block in full-width. However, there the cart block had no margin on the left hand-side margin and the checkout block had no margin on both sides. The screenshots on #5010 demonstrate this problem.
With this PR, I removed the full-width option so that these blocks can only use the wide option. When using the wide option, the margin problem no longer appears.
Testing
Cart
, theFilled Cart
and theEmpty Cart
only show the alignment optionsNone
andWide width
.None
andWide width
are available.User Facing Testing
Changelog