This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add support for decimal and thousand separators in the formatPrice function
#5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
ralucaStan
and removed request for
a team
mikejolley
added
status: needs review
block: cart
|
Size Change: +151 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
Aljullu
reviewed
Nov 19, 2021
There was a problem hiding this comment.
This is testing well for the Cart price, but doesn't seem to add a thousand separator to the quantity badge, did I understand the testing steps wrong?
Besides that, I think the third testing step needs to be updated:
- Change decimal separator to
,- Change thousand separator to
.
|
@Aljullu Clarified testing steps. This only change how prices are shown, not qty. |
Co-authored-by: Albert Juhé Lluveras <[email protected]>
Aljullu
approved these changes
Nov 19, 2021
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
nielslange
added a commit
that referenced
this pull request
Nov 23, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
…function (woocommerce#5188) * Format with decimal and thousands, with tests * Update packages/prices/utils/price.ts Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
…function (woocommerce#5188) * Format with decimal and thousands, with tests * Update packages/prices/utils/price.ts Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatPriceignores custom decimal and thousand symbols, instead defaulting to.for decimals.This PR fixes this by formatting the values with the correct (based on the provided currency) symbols from settings.
Fixes #5018
Screenshots
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
,.User Facing Testing
Same as above.
Changelog