This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add basic taxonomy block templates #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
|
Size Change: +9 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
tjcafferkey
reviewed
Nov 3, 2021
| @@ -25,7 +25,9 @@ interface Props { | |||
| const Edit = ( { attributes }: Props ) => { | |||
| const blockProps = useBlockProps(); | |||
| const templateTitle = | |||
| TEMPLATE_TITLES[ attributes.template ] ?? attributes.template; | |||
| TEMPLATES[ attributes.template ]?.title ?? attributes.template; | |||
| const templatePlaceholder = | |||
There was a problem hiding this comment.
Nice work, well considered!
tjcafferkey
reviewed
Nov 3, 2021
tjcafferkey
approved these changes
Nov 3, 2021
frontdevde
added
type: enhancement
nielslange
changed the title
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
…mmerce#5063) * Add taxonomy block templates * Change Category template display name * Check for product category/tag taxonomy explicitely * Group archive templates in LegacyTemplate
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
…mmerce#5063) * Add taxonomy block templates * Change Category template display name * Check for product category/tag taxonomy explicitely * Group archive templates in LegacyTemplate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WooCommerce merchants to be able to fully utilize block themes, we need the most important WooCommerce core PHP templates to be available as block templates.
This PR adds a block template version of the taxonomy-product-cat.php and taxonomy-product-tag.php templates.
Note that both templates are a special case in the sense that they utilize the
archive-producttemplate.Closes #5034
Closes #5035
Manual Testing
How to test the changes in this Pull Request:
Prerequisite: Please ensure you have a Block Template Theme activated such as TT1 and also the Gutenberg Plugin installed.
Product Category Pagetemplate from theGeneral templatessection./product-category/clothing/is identical to the behavior the same page without this PR applied.Product Tag Pagetemplate (e.g./product-tag/merch/)Once you have followed the above steps, add the same template files to your
theme-dir/block-templatesand change the file contents so you can differentiate between the Woo Block template and the Theme template. Repeat the above steps starting from Step 2 and confirm the Theme template is preferred over the Woo Blocks templateChangelog