This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add basic product archive block template #5049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
November 2, 2021 12:13
frontdevde
added
focus: FSE
Work related to prepare WooCommerce for FSE.
type: enhancement
The issue is a request for an enhancement.
focus: template
Related to API powering block template functionality in the Site Editor
status: needs review
labels
Nov 2, 2021
Size Change: +870 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
frontdevde
force-pushed
the
add/archive-product-block-template
branch
from
November 2, 2021 12:20
7dcbe17
to
ae090e9
Compare
tjcafferkey
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Works as expected and code LGTM.
This was referenced Nov 2, 2021
nielslange
changed the title
Store Editing Templates v1: add a basic Product Archive block template
Add basic product archive block template
Nov 15, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
woocommerce#5049) * Add the Archive Product block template * Use template slug if no template title is set * Add page icon as per design * Add the basic archive product block template
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
woocommerce#5049) * Add the Archive Product block template * Use template slug if no template title is set * Add page icon as per design * Add the basic archive product block template
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: FSE
Work related to prepare WooCommerce for FSE.
focus: template
Related to API powering block template functionality in the Site Editor
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WooCommerce merchants to be able to fully utilize block themes, we need the most important WooCommerce core PHP templates to be available as block templates.
This PR adds a block template version of the archive-product.php template.
Closes #5033
Manual Testing
How to test the changes in this Pull Request:
Prerequisite: Please ensure you have a Block Template Theme activated such as TT1 and also the Gutenberg Plugin installed.
Product Archive Page
template from theGeneral templates
section./shop
is identical to the behavior on/shop
without this PR applied.Once you have followed the above steps, add the same template files to your
theme-dir/block-templates
and change the file contents so you can differentiate between the Woo Block template and the Theme template. Repeat the above steps starting from Step 2 and confirm the Theme template is preferred over the Woo Blocks templateChangelog