This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Graduate __experimental_woocommerce_blocks_checkout_order_processed action to stable
#5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
focus: rest api
rubikuserbot
requested review from
a team and
ralucaStan
and removed request for
a team
|
Size Change: +303 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
I also mentioned this hook is deprecated in the experimental interfaces doc.
opr
changed the title
__experimental_woocommerce_blocks_checkout_order_processed action__experimental_woocommerce_blocks_checkout_order_processed action to stable
mikejolley
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
And approving this one too. Just take note of the comments in #5015 (review) I'm sure you're already aware of.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
nielslange
added
focus: documentation
3 tasks
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
… action to stable (woocommerce#5014) * Deprecate __experimental_woocommerce_blocks_checkout_order_processed * Update docs to reflect new hook name I also mentioned this hook is deprecated in the experimental interfaces doc. * Update deprecated tag in docblock * Fix typo in deprecated docblock * Send args to do_action_deprecated in an array * Amend deprecated tag and add version numbers
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
… action to stable (woocommerce#5014) * Deprecate __experimental_woocommerce_blocks_checkout_order_processed * Update docs to reflect new hook name I also mentioned this hook is deprecated in the experimental interfaces doc. * Update deprecated tag in docblock * Fix typo in deprecated docblock * Send args to do_action_deprecated in an array * Amend deprecated tag and add version numbers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will deprecate the
__experimental_woocommerce_blocks_checkout_order_processedaction and replace it withwoocommerce_blocks_checkout_order_processed.It also updates the docs relating to this hook. All references to the now deprecated hook have been replaced with the new hook, besides the one in the experimental interfaces document, which has changed to note that the prefixed hook is now deprecated.
Fixes #4998
Manual Testing
How to test the changes in this Pull Request:
functions.phpfile:wp-config.phpfile:debug.logfile and ensure there's a deprecation message logged for__experimental_woocommerce_blocks_checkout_order_processed.Changelog