This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add render logic to BlockTemplateController #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
status: needs review
focus: FSE
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
Size Change: +11.3 kB (+1%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
tjcafferkey
force-pushed
the
update/block-template-controller-render-template
branch
from
84b718e to
be458b7
Compare
Aljullu
approved these changes
Oct 26, 2021
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
Failing tests are related to these changes. Need to investigate. |
dinhtungdu
reviewed
Oct 28, 2021
dinhtungdu
reviewed
Oct 29, 2021
dinhtungdu
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
@tjcafferkey LGTM! Just one minor issue then we can merge this PR. Pre-approving! Tested and it worked great on my end.
opr
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
This works well! The testing instructions should be updated to correctly reflect the precedence of Theme > Blocks > Core though, seems they're swapped in this PR description.
Approving, but not merging due to an outstanding suggestion that you should consider.
|
@tjcafferkey Testing this PR again, I notice the header and footer didn't load on my test site using the TT1 Block theme. When I edit the single product template in the Site Editor for the first time, I need to choose the template part for the header and footer. Screenshots
|
|
Using this template I can load the header and footer out of the box |
|
Thanks @dinhtungdu, you are right about my template markup. I just never updated it (have it on a clipboard) seeing as I was focusing more on the mechanism of loading the templates rather than the template itself. Thanks for the new markup I'll update so I can use this from now on 😄 |
Co-authored-by: Tung Du <[email protected]>
tjcafferkey
deleted the
update/block-template-controller-render-template
branch
nielslange
changed the title
nielslange
added
the
type: enhancement
frontdevde
added
the
skip-changelog
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Add render logic to BlockTemplatesController * Comment out action to test e2e tests * Add add_action back into initialise render method * Check function exists before using it * Change hook from wp to template_redirect * Update src/BlockTemplatesController.php Co-authored-by: Tung Du <[email protected]> Co-authored-by: Tung Du <[email protected]>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Add render logic to BlockTemplatesController * Comment out action to test e2e tests * Add add_action back into initialise render method * Check function exists before using it * Change hook from wp to template_redirect * Update src/BlockTemplatesController.php Co-authored-by: Tung Du <[email protected]> Co-authored-by: Tung Du <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4971
Testing
Manual Testing
How to test the changes in this Pull Request:
single-product.htmltemplate and refresh your Product Page. Confirm the Woo Blocks template is being rendered./theme-dir/block-templates/single-product.html/woo-blocks/templates/block-templates/single-product.htmlChangelog