This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Cart i2 Express Payment Method Spacing #4974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
skip-changelog
rubikuserbot
requested review from
a team and
nielslange
and removed request for
a team
mikejolley
changed the title
|
Size Change: +222 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
senadir
suggested changes
Oct 20, 2021
|
I'm seeing conflict with styles coming from Cart i1. How about we merge this and handle styles in the migration PR? |
senadir
approved these changes
Oct 20, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styling changes to improve the spacing between express payment blocks in cart i2.
Fixes #4960
Screenshots
Spacing after these changes, editor + frontend:
Testing
For testing, use the cart i2 block and confirm the style of the sidebar matches the above. You'll need Stripe active in order to see the express payment methods, and on the frontend, a supported browser (chrome).