This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: Filter button is not aligned with the input field #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerrad
requested review from
a team and
Aljullu
and removed request for
a team
|
Size Change: -17.4 kB (-1%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
dinhtungdu
added
type: bug
Aljullu
reviewed
Sep 23, 2021
There was a problem hiding this comment.
This is looking good, thanks for working on this @dinhtungdu! There are a couple of edge cases that I think might be worth addressing in this PR if that sounds good.
If I add the block directly into a page so it occupies the entire width, would it be possible to make the input field to span almost to touch the button (only leaving a small margin between them)?
| Current | Desired |
|---|---|
 |
 |
Another case is when adding the block inside the Columns block (with three or more columns), then it's still breaking into two lines:
| Current | Desired |
|---|---|
 |
 |
|
@Aljullu Thanks for the head-up! I updated the PR to cover the cases you mentioned above. Please take another look! |
Aljullu
reviewed
Sep 28, 2021
There was a problem hiding this comment.
Thanks for updating this PR @dinhtungdu! I found one last edge case:
If you add the Filter block inside a three-column block, it overflows the available space (you can see it if you make its column to have a colored background):
I spent some time trying to figure out what's going on here. It looks like min-width: 0 is ignored in inputs if their size attribute forces them to be wider. I wonder if we could set the input size to be something very low and then set the min-width to 100%. I guess this way it would not overflow?
|
@Aljullu thanks for the catch! I fixed the issue and tested it on Chrome/Firefox/Safari. Please take another look! |
Aljullu
approved these changes
Sep 29, 2021
| .wc-block-attribute-filter-dropdown { | ||
| flex-grow: 1; | ||
| max-width: unset; | ||
| width: 0; |
There was a problem hiding this comment.
Ah, much better and simpler fix than the one I suggested. Good catch! 👌
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2560
This PR fixes the alignment issue of the Filter Products by Attribute block when using Dropdown as the display type. This PR also fixes the height of the input field, makes it equal to the height of the filter button.
Manual Testing
How to test the changes in this Pull Request:
Performance Impact
Changelog